Skip to content

align on ts 5.7.3 #8921

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 4 commits into from
Closed

align on ts 5.7.3 #8921

wants to merge 4 commits into from

Conversation

@birkskyum
Copy link
Member

@birkskyum birkskyum commented Apr 1, 2025 •
edited
Loading

We use a mix of ts versions:
5.4.5
5.6.3
5.7.2

This align all to 5.7.3

In order to support 5.7.3 for vue-query-devtools, it was necessary to bump the minor version of vue-tsc

@nx-cloud
Copy link

nx-cloud bot commented Apr 1, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit de2a208.

Command Status Duration Result
nx affected --targets=test:sherif,test:knip,tes... ❌ Failed 3m 2s View ↗
nx run-many --target=build --exclude=examples/*... ❌ Failed 1m 56s View ↗

☁️ Nx Cloud last updated this comment at 2025-04-01 13:33:31 UTC

@pkg-pr-new
Copy link

pkg-pr-new bot commented Apr 1, 2025

More templates

@tanstack/angular-query-devtools-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-devtools-experimental@8921

@tanstack/angular-query-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-experimental@8921

@tanstack/query-async-storage-persister

npm i https://pkg.pr.new/@tanstack/query-async-storage-persister@8921

@tanstack/query-broadcast-client-experimental

npm i https://pkg.pr.new/@tanstack/query-broadcast-client-experimental@8921

@tanstack/eslint-plugin-query

npm i https://pkg.pr.new/@tanstack/eslint-plugin-query@8921

@tanstack/query-core

npm i https://pkg.pr.new/@tanstack/query-core@8921

@tanstack/query-devtools

npm i https://pkg.pr.new/@tanstack/query-devtools@8921

@tanstack/query-persist-client-core

npm i https://pkg.pr.new/@tanstack/query-persist-client-core@8921

@tanstack/query-sync-storage-persister

npm i https://pkg.pr.new/@tanstack/query-sync-storage-persister@8921

@tanstack/react-query

npm i https://pkg.pr.new/@tanstack/react-query@8921

@tanstack/react-query-devtools

npm i https://pkg.pr.new/@tanstack/react-query-devtools@8921

@tanstack/react-query-next-experimental

npm i https://pkg.pr.new/@tanstack/react-query-next-experimental@8921

@tanstack/react-query-persist-client

npm i https://pkg.pr.new/@tanstack/react-query-persist-client@8921

@tanstack/solid-query

npm i https://pkg.pr.new/@tanstack/solid-query@8921

@tanstack/solid-query-devtools

npm i https://pkg.pr.new/@tanstack/solid-query-devtools@8921

@tanstack/solid-query-persist-client

npm i https://pkg.pr.new/@tanstack/solid-query-persist-client@8921

@tanstack/svelte-query

npm i https://pkg.pr.new/@tanstack/svelte-query@8921

@tanstack/svelte-query-devtools

npm i https://pkg.pr.new/@tanstack/svelte-query-devtools@8921

@tanstack/svelte-query-persist-client

npm i https://pkg.pr.new/@tanstack/svelte-query-persist-client@8921

@tanstack/vue-query

npm i https://pkg.pr.new/@tanstack/vue-query@8921

@tanstack/vue-query-devtools

npm i https://pkg.pr.new/@tanstack/vue-query-devtools@8921

commit: f3b0ba4

@github-actions
Copy link
Contributor

github-actions bot commented Apr 1, 2025

Sizes for commit f3b0ba4:

Branch Bundle Size
Main
This PR

@TkDodo
Copy link
Collaborator

TkDodo commented Apr 1, 2025

I think angular doesn’t yet support this version?

@birkskyum
Copy link
Member Author

birkskyum commented Apr 1, 2025 •
edited
Loading

It's supported from 19.2.x
https://angular.dev/reference/versions#actively-supported-versions

I've downgraded to 5.7.3. It should be sufficient.

@birkskyum birkskyum force-pushed the align-on-ts-5.8.2 branch from 5576e67 to de2a208 Compare April 1, 2025 13:29
@birkskyum birkskyum changed the title align on ts 5.8.2 align on ts 5.7.3 Apr 1, 2025
@birkskyum birkskyum closed this Apr 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

package: angular-query-devtools-experimental package: angular-query-experimental package: vue-query-devtools

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@birkskyum @TkDodo