Skip to content

Conversation

@ruisaraiva19
Copy link
Contributor

@ruisaraiva19 ruisaraiva19 commented Aug 19, 2020

This uses bahmutov/npm-install to install NPM dependencies with caching without any configuration.
Also uses cycjimmy/semantic-release-action as a wrapper for Semantic Release.

@vercel
Copy link

vercel bot commented Aug 19, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/tannerlinsley/react-query/95di1s8bp
✅ Preview: https://react-query-git-fork-ruisaraiva19-chore-update-actions.tannerlinsley.vercel.app

@ruisaraiva19 ruisaraiva19 changed the title chore(actions): add cache to NPM packages on GitHub actions chore(actions): add cache to NPM dependencies on GitHub actions Aug 19, 2020
@tannerlinsley
Copy link
Member

Nice! Could you add this to react-table and react-charts, and react-virtual too? 😉

@tannerlinsley tannerlinsley merged commit 2b26c1a into TanStack:master Aug 20, 2020
@ruisaraiva19 ruisaraiva19 deleted the chore/update-actions branch August 20, 2020 05:38
@ruisaraiva19
Copy link
Contributor Author

Nice! Could you add this to react-table and react-charts, and react-virtual too? 😉

Sure!

@ruisaraiva19
Copy link
Contributor Author

ruisaraiva19 commented Aug 20, 2020

@tannerlinsley one note regarding the NPM_TOKEN you have configured on the project.

The action is throwing the following error:
image

You can follow these steps to fix the issue:

Log in to npm

npm login

Change 2FA mode to auth-only

npm profile enable-2fa auth-only

Or we can revert the semantic-release step logic since it was working fine 😉 .

@tannerlinsley
Copy link
Member

tannerlinsley commented Aug 20, 2020 via email

@ruisaraiva19
Copy link
Contributor Author

I haven’t changed anything And It was working before. You sure it’s Pulling from the right env variable? Tanner Linsley

I'm using the same variables you have before. I'm going to revert to the previously working semantic release step code. #895 895

@tannerlinsley
Copy link
Member

🎉 This PR is included in version 2.7.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@ruisaraiva19
Copy link
Contributor Author

ruisaraiva19 commented Aug 20, 2020

Nice! Could you add this to react-table and react-charts, and react-virtual too? 😉

@tannerlinsley Here they are:
react-table: TanStack/table#2652
react-charts: TanStack/react-charts#115
react-virtual: TanStack/virtual#50

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants