Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(eslint-plugin-query): expect-expect warning for expectArrayEqualIgnoreOrder #8143

Merged
merged 2 commits into from
Oct 9, 2024
Merged

fix(eslint-plugin-query): expect-expect warning for expectArrayEqualIgnoreOrder #8143

merged 2 commits into from
Oct 9, 2024

Conversation

saul-atomrigs
Copy link
Contributor

Captura de pantalla 2024-10-08 a las 11 30 58 a  m

ESLint's expect-expect rule doesn't recognize that the expect function is being used indirectly via expectArrayEqualIgnoreOrder. This PR adds a global config to fix it.

@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Oct 8, 2024 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 633c665. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 2 targets

Sent with 💌 from NxCloud.

@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Oct 8, 2024 •
edited
Loading

Open in Stackblitz

More templates

@tanstack/angular-query-devtools-experimental

pnpm add https://pkg.pr.new/@tanstack/angular-query-devtools-experimental@8143

@tanstack/eslint-plugin-query

pnpm add https://pkg.pr.new/@tanstack/eslint-plugin-query@8143

@tanstack/angular-query-experimental

pnpm add https://pkg.pr.new/@tanstack/angular-query-experimental@8143

@tanstack/query-async-storage-persister

pnpm add https://pkg.pr.new/@tanstack/query-async-storage-persister@8143

@tanstack/query-broadcast-client-experimental

pnpm add https://pkg.pr.new/@tanstack/query-broadcast-client-experimental@8143

@tanstack/query-core

pnpm add https://pkg.pr.new/@tanstack/query-core@8143

@tanstack/query-devtools

pnpm add https://pkg.pr.new/@tanstack/query-devtools@8143

@tanstack/query-persist-client-core

pnpm add https://pkg.pr.new/@tanstack/query-persist-client-core@8143

@tanstack/query-sync-storage-persister

pnpm add https://pkg.pr.new/@tanstack/query-sync-storage-persister@8143

@tanstack/react-query-devtools

pnpm add https://pkg.pr.new/@tanstack/react-query-devtools@8143

@tanstack/react-query

pnpm add https://pkg.pr.new/@tanstack/react-query@8143

@tanstack/react-query-next-experimental

pnpm add https://pkg.pr.new/@tanstack/react-query-next-experimental@8143

@tanstack/react-query-persist-client

pnpm add https://pkg.pr.new/@tanstack/react-query-persist-client@8143

@tanstack/solid-query

pnpm add https://pkg.pr.new/@tanstack/solid-query@8143

@tanstack/solid-query-devtools

pnpm add https://pkg.pr.new/@tanstack/solid-query-devtools@8143

@tanstack/solid-query-persist-client

pnpm add https://pkg.pr.new/@tanstack/solid-query-persist-client@8143

@tanstack/svelte-query-devtools

pnpm add https://pkg.pr.new/@tanstack/svelte-query-devtools@8143

@tanstack/svelte-query

pnpm add https://pkg.pr.new/@tanstack/svelte-query@8143

@tanstack/svelte-query-persist-client

pnpm add https://pkg.pr.new/@tanstack/svelte-query-persist-client@8143

@tanstack/vue-query

pnpm add https://pkg.pr.new/@tanstack/vue-query@8143

@tanstack/vue-query-devtools

pnpm add https://pkg.pr.new/@tanstack/vue-query-devtools@8143

commit: 633c665

@saul-atomrigs saul-atomrigs marked this pull request as draft October 8, 2024 02:50
@codecov Codecov
Copy link

codecov bot commented Oct 8, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.82%. Comparing base (495b086) to head (633c665).
Report is 9 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           main    #8143       +/-   ##
=========================================
+ Coverage      0   87.82%   +87.82%     
=========================================
  Files         0       15       +15     
  Lines         0      493      +493     
  Branches      0      183      +183     
=========================================
+ Hits          0      433      +433     
- Misses        0       46       +46     
- Partials      0       14       +14
Components Coverage Δ
@tanstack/angular-query-devtools-experimental ∅ <ø> (∅)
@tanstack/angular-query-experimental ∅ <ø> (∅)
@tanstack/eslint-plugin-query 87.82% <ø> (∅)
@tanstack/query-async-storage-persister ∅ <ø> (∅)
@tanstack/query-broadcast-client-experimental ∅ <ø> (∅)
@tanstack/query-codemods ∅ <ø> (∅)
@tanstack/query-core ∅ <ø> (∅)
@tanstack/query-devtools ∅ <ø> (∅)
@tanstack/query-persist-client-core ∅ <ø> (∅)
@tanstack/query-sync-storage-persister ∅ <ø> (∅)
@tanstack/react-query ∅ <ø> (∅)
@tanstack/react-query-devtools ∅ <ø> (∅)
@tanstack/react-query-next-experimental ∅ <ø> (∅)
@tanstack/react-query-persist-client ∅ <ø> (∅)
@tanstack/solid-query ∅ <ø> (∅)
@tanstack/solid-query-devtools ∅ <ø> (∅)
@tanstack/solid-query-persist-client ∅ <ø> (∅)
@tanstack/svelte-query ∅ <ø> (∅)
@tanstack/svelte-query-devtools ∅ <ø> (∅)
@tanstack/svelte-query-persist-client ∅ <ø> (∅)
@tanstack/vue-query ∅ <ø> (∅)
@tanstack/vue-query-devtools ∅ <ø> (∅)

@saul-atomrigs saul-atomrigs marked this pull request as ready for review October 8, 2024 04:21
@TkDodo TkDodo merged commit 85a525a into TanStack:main Oct 9, 2024
8 checks passed
This was referenced Oct 31, 2024
Closed
Closed
Merged
@Bancha-t Bancha-t mentioned this pull request Oct 31, 2024
Open
@Bonniemarie216 Bonniemarie216 mentioned this pull request Oct 31, 2024
Open
@zntb zntb mentioned this pull request Nov 1, 2024
Merged
This was referenced Nov 2, 2024
Closed
Closed
@jwinr jwinr mentioned this pull request Nov 4, 2024
Merged
@CalPinSW CalPinSW mentioned this pull request Nov 5, 2024
Merged
@GouravNG GouravNG mentioned this pull request Nov 5, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TkDodo TkDodo TkDodo approved these changes

Assignees
No one assigned
Labels
package: eslint-plugin-query
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@saul-atomrigs @TkDodo