Skip to content

fix(types): Fix defaultConfig typing for makeQueryCache #807

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tannerlinsley merged 6 commits into from
Jul 31, 2020
Merged

fix(types): Fix defaultConfig typing for makeQueryCache #807

tannerlinsley merged 6 commits into from
Jul 31, 2020

Conversation

@kamranayub
Copy link
Contributor

@kamranayub kamranayub commented Jul 29, 2020 •
edited
Loading

Fixes #806

Changes

  • Fix defaultConfig typing of makeQueryCache

@vercel
Copy link

vercel bot commented Jul 29, 2020 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/tannerlinsley/react-query/mwpbxmfyw
✅ Preview: https://react-query-git-fork-kamranayub-fix-gh-806default-config-types.tannerlinsley.vercel.app

kamranayub
kamranayub commented Jul 29, 2020
View reviewed changes
types/test.ts
queryCache.getQueryData('queryKey');
queryCache.getQueryData(true);
queryCache.getQueryData((query) => true);
queryCache.getQueryData(['queryKey'])
Copy link
Contributor Author

@kamranayub kamranayub Jul 29, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, seems prettier took effect here

Copy link
Contributor Author

@kamranayub kamranayub Jul 29, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tannerlinsley would you prefer I revert these formatting changes?

@kamranayub
Copy link
Contributor Author

kamranayub commented Jul 29, 2020

Tests seem to be failing with unrelated issues, probably #751

@kamranayub
Copy link
Contributor Author

kamranayub commented Jul 30, 2020 •
edited
Loading

See #806 (comment) but even with TS source, this will be an issue until the declaration files are generated since the package typings resolve to types/index.d.ts still.

@kamranayub kamranayub marked this pull request as ready for review July 30, 2020 15:09
@tannerlinsley
Copy link
Member

tannerlinsley commented Jul 31, 2020

I'll merge for now.

@tannerlinsley tannerlinsley merged commit 46a5584 into TanStack:master Jul 31, 2020
@tannerlinsley
Copy link
Member

tannerlinsley commented Jul 31, 2020

🎉 This PR is included in version 2.5.10 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

released

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

bug(types): defaultConfig for makeQueryCache is typed incorrectly

2 participants

@kamranayub @tannerlinsley