-
-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(eslint-plugin): use typescript-eslint v8 stable #7968
feat(eslint-plugin): use typescript-eslint v8 stable #7968
Conversation
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 8390136. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 2 targetsSent with 💌 from NxCloud. |
commit: @tanstack/angular-query-devtools-experimental
@tanstack/angular-query-experimental
@tanstack/eslint-plugin-query
@tanstack/query-async-storage-persister
@tanstack/query-broadcast-client-experimental
@tanstack/query-core
@tanstack/query-devtools
@tanstack/query-persist-client-core
@tanstack/query-sync-storage-persister
@tanstack/react-query
@tanstack/react-query-devtools
@tanstack/react-query-next-experimental
@tanstack/react-query-persist-client
@tanstack/solid-query
@tanstack/solid-query-devtools
@tanstack/solid-query-persist-client
@tanstack/svelte-query
@tanstack/svelte-query-devtools
@tanstack/svelte-query-persist-client
@tanstack/vue-query
@tanstack/vue-query-devtools
More templates
|
now types are failing :/ |
28e5649
to
e1c48bb
Compare
packages/eslint-plugin-query/src/__tests__/exhaustive-deps.test.ts
Outdated
Show resolved
Hide resolved
…pescript-eslintutils-stable-v8
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7968 +/- ##
==========================================
+ Coverage 45.08% 45.09% +0.01%
==========================================
Files 188 188
Lines 7147 7149 +2
Branches 1605 1607 +2
==========================================
+ Hits 3222 3224 +2
Misses 3562 3562
Partials 363 363 |
@tanstack/eslint-plugin-query is currently setting the dependency for @typescript-eslint/utils to use v8.0.0-alpha.30.
As typescript-eslint has released the stable v8, this project could use @typescript-eslint/rule-tester and @typescript-eslint/utils with version ^8.3.0, requiring the peerDependencies for ESLint to be changed to ^8.57.0 || ^9.0.0.
reference: #7967