Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(eslint-plugin): use typescript-eslint v8 stable #7968

Conversation

rivajunior
Copy link
Contributor

@tanstack/eslint-plugin-query is currently setting the dependency for @typescript-eslint/utils to use v8.0.0-alpha.30.

As typescript-eslint has released the stable v8, this project could use @typescript-eslint/rule-tester and @typescript-eslint/utils with version ^8.3.0, requiring the peerDependencies for ESLint to be changed to ^8.57.0 || ^9.0.0.

reference: #7967

Copy link

nx-cloud bot commented Aug 27, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 8390136. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 2 targets

Sent with 💌 from NxCloud.

Copy link

pkg-pr-new bot commented Aug 27, 2024

commit: 8390136

@tanstack/angular-query-devtools-experimental

pnpm add https://pkg.pr.new/@tanstack/angular-query-devtools-experimental@7968

@tanstack/angular-query-experimental

pnpm add https://pkg.pr.new/@tanstack/angular-query-experimental@7968

@tanstack/eslint-plugin-query

pnpm add https://pkg.pr.new/@tanstack/eslint-plugin-query@7968

@tanstack/query-async-storage-persister

pnpm add https://pkg.pr.new/@tanstack/query-async-storage-persister@7968

@tanstack/query-broadcast-client-experimental

pnpm add https://pkg.pr.new/@tanstack/query-broadcast-client-experimental@7968

@tanstack/query-core

pnpm add https://pkg.pr.new/@tanstack/query-core@7968

@tanstack/query-devtools

pnpm add https://pkg.pr.new/@tanstack/query-devtools@7968

@tanstack/query-persist-client-core

pnpm add https://pkg.pr.new/@tanstack/query-persist-client-core@7968

@tanstack/query-sync-storage-persister

pnpm add https://pkg.pr.new/@tanstack/query-sync-storage-persister@7968

@tanstack/react-query

pnpm add https://pkg.pr.new/@tanstack/react-query@7968

@tanstack/react-query-devtools

pnpm add https://pkg.pr.new/@tanstack/react-query-devtools@7968

@tanstack/react-query-next-experimental

pnpm add https://pkg.pr.new/@tanstack/react-query-next-experimental@7968

@tanstack/react-query-persist-client

pnpm add https://pkg.pr.new/@tanstack/react-query-persist-client@7968

@tanstack/solid-query

pnpm add https://pkg.pr.new/@tanstack/solid-query@7968

@tanstack/solid-query-devtools

pnpm add https://pkg.pr.new/@tanstack/solid-query-devtools@7968

@tanstack/solid-query-persist-client

pnpm add https://pkg.pr.new/@tanstack/solid-query-persist-client@7968

@tanstack/svelte-query

pnpm add https://pkg.pr.new/@tanstack/svelte-query@7968

@tanstack/svelte-query-devtools

pnpm add https://pkg.pr.new/@tanstack/svelte-query-devtools@7968

@tanstack/svelte-query-persist-client

pnpm add https://pkg.pr.new/@tanstack/svelte-query-persist-client@7968

@tanstack/vue-query

pnpm add https://pkg.pr.new/@tanstack/vue-query@7968

@tanstack/vue-query-devtools

pnpm add https://pkg.pr.new/@tanstack/vue-query-devtools@7968

Open in Stackblitz

More templates

@TkDodo
Copy link
Collaborator

TkDodo commented Aug 27, 2024

now types are failing :/

@rivajunior rivajunior marked this pull request as draft August 27, 2024 16:53
@rivajunior rivajunior force-pushed the update-tanstackeslint-plugin-query-to-use-typescript-eslintutils-stable-v8 branch from 28e5649 to e1c48bb Compare August 27, 2024 17:53
@rivajunior rivajunior marked this pull request as ready for review August 27, 2024 17:54
@lachlancollins lachlancollins changed the title feat(eslint-plugin-query): use @typescript-eslint/utils stable v8 feat(eslint-plugin): use typescript-eslint v8 stable Aug 30, 2024
Copy link

codecov bot commented Aug 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.09%. Comparing base (eee80af) to head (8390136).
Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #7968      +/-   ##
==========================================
+ Coverage   45.08%   45.09%   +0.01%     
==========================================
  Files         188      188              
  Lines        7147     7149       +2     
  Branches     1605     1607       +2     
==========================================
+ Hits         3222     3224       +2     
  Misses       3562     3562              
  Partials      363      363              
Components Coverage Δ
@tanstack/angular-query-devtools-experimental ∅ <ø> (∅)
@tanstack/angular-query-experimental 86.58% <ø> (ø)
@tanstack/eslint-plugin-query 86.30% <100.00%> (+0.06%) ⬆️
@tanstack/query-async-storage-persister 43.85% <ø> (ø)
@tanstack/query-broadcast-client-experimental ∅ <ø> (∅)
@tanstack/query-codemods 0.00% <ø> (ø)
@tanstack/query-core 92.83% <ø> (ø)
@tanstack/query-devtools 5.24% <ø> (ø)
@tanstack/query-persist-client-core 57.73% <ø> (ø)
@tanstack/query-sync-storage-persister 82.50% <ø> (ø)
@tanstack/react-query 92.50% <ø> (ø)
@tanstack/react-query-devtools 10.71% <ø> (ø)
@tanstack/react-query-next-experimental ∅ <ø> (∅)
@tanstack/react-query-persist-client 100.00% <ø> (ø)
@tanstack/solid-query 78.20% <ø> (ø)
@tanstack/solid-query-devtools ∅ <ø> (∅)
@tanstack/solid-query-persist-client 100.00% <ø> (ø)
@tanstack/svelte-query 87.33% <ø> (ø)
@tanstack/svelte-query-devtools ∅ <ø> (∅)
@tanstack/svelte-query-persist-client 100.00% <ø> (ø)
@tanstack/vue-query 71.42% <ø> (ø)
@tanstack/vue-query-devtools ∅ <ø> (∅)

@lachlancollins lachlancollins merged commit f3aad7c into TanStack:main Aug 30, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants