Skip to content

fix(eslint-plugin): handle ternary expressions in queryFn for exhaustive-deps rule #7747

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 17, 2024
Merged

fix(eslint-plugin): handle ternary expressions in queryFn for exhaustive-deps rule #7747

merged 1 commit into from
Jul 17, 2024

Conversation

@Newbie012
Copy link
Collaborator

@Newbie012 Newbie012 commented Jul 17, 2024 •
edited by lachlancollins
Loading

fixes #7666

@nx-cloud
Copy link

nx-cloud bot commented Jul 17, 2024 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 5092530. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 2 targets

Sent with 💌 from NxCloud.

@Newbie012 Newbie012 mentioned this pull request Jul 17, 2024
Closed
@pkg-pr-new
Copy link

pkg-pr-new bot commented Jul 17, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

commit: 5092530

@tanstack/angular-query-devtools-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-devtools-experimental@7747

@tanstack/angular-query-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-experimental@7747

@tanstack/eslint-plugin-query

npm i https://pkg.pr.new/@tanstack/eslint-plugin-query@7747

@tanstack/query-async-storage-persister

npm i https://pkg.pr.new/@tanstack/query-async-storage-persister@7747

@tanstack/query-broadcast-client-experimental

npm i https://pkg.pr.new/@tanstack/query-broadcast-client-experimental@7747

@tanstack/query-core

npm i https://pkg.pr.new/@tanstack/query-core@7747

@tanstack/query-devtools

npm i https://pkg.pr.new/@tanstack/query-devtools@7747

@tanstack/query-persist-client-core

npm i https://pkg.pr.new/@tanstack/query-persist-client-core@7747

@tanstack/query-sync-storage-persister

npm i https://pkg.pr.new/@tanstack/query-sync-storage-persister@7747

@tanstack/react-query

npm i https://pkg.pr.new/@tanstack/react-query@7747

@tanstack/react-query-devtools

npm i https://pkg.pr.new/@tanstack/react-query-devtools@7747

@tanstack/react-query-next-experimental

npm i https://pkg.pr.new/@tanstack/react-query-next-experimental@7747

@tanstack/react-query-persist-client

npm i https://pkg.pr.new/@tanstack/react-query-persist-client@7747

@tanstack/solid-query

npm i https://pkg.pr.new/@tanstack/solid-query@7747

@tanstack/solid-query-devtools

npm i https://pkg.pr.new/@tanstack/solid-query-devtools@7747

@tanstack/solid-query-persist-client

npm i https://pkg.pr.new/@tanstack/solid-query-persist-client@7747

@tanstack/svelte-query

npm i https://pkg.pr.new/@tanstack/svelte-query@7747

@tanstack/svelte-query-devtools

npm i https://pkg.pr.new/@tanstack/svelte-query-devtools@7747

@tanstack/svelte-query-persist-client

npm i https://pkg.pr.new/@tanstack/svelte-query-persist-client@7747

@tanstack/vue-query

npm i https://pkg.pr.new/@tanstack/vue-query@7747

@tanstack/vue-query-devtools

npm i https://pkg.pr.new/@tanstack/vue-query-devtools@7747

templates

@codecov
Copy link

codecov bot commented Jul 17, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 84.14%. Comparing base (23b9a19) to head (5092530).
Report is 10 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #7747       +/-   ##
===========================================
+ Coverage   44.56%   84.14%   +39.58%     
===========================================
  Files         185       11      -174     
  Lines        7062      347     -6715     
  Branches     1554      125     -1429     
===========================================
- Hits         3147      292     -2855     
+ Misses       3552       41     -3511     
+ Partials      363       14      -349
Components Coverage Δ
@tanstack/angular-query-devtools-experimental ∅ <ø> (∅)
@tanstack/angular-query-experimental ∅ <ø> (∅)
@tanstack/eslint-plugin-query 84.14% <75.00%> (-0.22%) ⬇️
@tanstack/query-async-storage-persister ∅ <ø> (∅)
@tanstack/query-broadcast-client-experimental ∅ <ø> (∅)
@tanstack/query-codemods ∅ <ø> (∅)
@tanstack/query-core ∅ <ø> (∅)
@tanstack/query-devtools ∅ <ø> (∅)
@tanstack/query-persist-client-core ∅ <ø> (∅)
@tanstack/query-sync-storage-persister ∅ <ø> (∅)
@tanstack/react-query ∅ <ø> (∅)
@tanstack/react-query-devtools ∅ <ø> (∅)
@tanstack/react-query-next-experimental ∅ <ø> (∅)
@tanstack/react-query-persist-client ∅ <ø> (∅)
@tanstack/solid-query ∅ <ø> (∅)
@tanstack/solid-query-devtools ∅ <ø> (∅)
@tanstack/solid-query-persist-client ∅ <ø> (∅)
@tanstack/svelte-query ∅ <ø> (∅)
@tanstack/svelte-query-devtools ∅ <ø> (∅)
@tanstack/svelte-query-persist-client ∅ <ø> (∅)
@tanstack/vue-query ∅ <ø> (∅)
@tanstack/vue-query-devtools ∅ <ø> (∅)

@lachlancollins lachlancollins merged commit 4c503c5 into main Jul 17, 2024
@lachlancollins lachlancollins deleted the fix-ternary-expression-handling branch July 17, 2024 23:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lachlancollins lachlancollins lachlancollins approved these changes

Assignees

No one assigned

Labels

package: eslint-plugin-query

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

eslint-plugin-query: skipToken breaks exhaustive queryKeys rule

3 participants

@Newbie012 @lachlancollins