Skip to content

Conversation

@lachlancollins
Copy link
Member

As I explained in #7605, to make pre-5.0 types work, the root tsconfig needed to be changed. The default moduleResolution is now "Node" rather than "Bundler", and project-level tsconfigs add "Bundler" as an override.

Tests are added for TS 4.7, 4.8, and 4.9 to select projects (and can be easily added to the others as required).

@vercel
Copy link

vercel bot commented Jun 25, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
query ⬜️ Ignored (Inspect) Jun 25, 2024 11:11am

@nx-cloud
Copy link

nx-cloud bot commented Jun 25, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 063efcc. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 063efcc:

Sandbox Source
@tanstack/query-example-angular-basic Configuration
@tanstack/query-example-react-basic-typescript Configuration
@tanstack/query-example-solid-basic-typescript Configuration
@tanstack/query-example-svelte-basic Configuration
@tanstack/query-example-vue-basic Configuration

@codecov
Copy link

codecov bot commented Jun 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 43.88%. Comparing base (8253a80) to head (063efcc).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #7618   +/-   ##
=======================================
  Coverage   43.88%   43.88%           
=======================================
  Files         184      184           
  Lines        7029     7029           
  Branches     1536     1535    -1     
=======================================
  Hits         3085     3085           
  Misses       3578     3578           
  Partials      366      366           
Components Coverage Δ
@tanstack/angular-query-devtools-experimental ∅ <ø> (∅)
@tanstack/angular-query-experimental 86.58% <ø> (ø)
@tanstack/eslint-plugin-query 85.46% <ø> (ø)
@tanstack/query-async-storage-persister 43.85% <ø> (ø)
@tanstack/query-broadcast-client-experimental ∅ <ø> (∅)
@tanstack/query-codemods 0.00% <ø> (ø)
@tanstack/query-core 92.79% <ø> (ø)
@tanstack/query-devtools 5.24% <ø> (ø)
@tanstack/query-persist-client-core 57.73% <ø> (ø)
@tanstack/query-sync-storage-persister 82.50% <ø> (ø)
@tanstack/react-query 92.72% <ø> (ø)
@tanstack/react-query-devtools 10.71% <ø> (ø)
@tanstack/react-query-next-experimental ∅ <ø> (∅)
@tanstack/react-query-persist-client 100.00% <ø> (ø)
@tanstack/solid-query 78.06% <ø> (ø)
@tanstack/solid-query-devtools ∅ <ø> (∅)
@tanstack/solid-query-persist-client 100.00% <ø> (ø)
@tanstack/svelte-query 68.66% <ø> (ø)
@tanstack/svelte-query-devtools ∅ <ø> (∅)
@tanstack/svelte-query-persist-client 100.00% <ø> (ø)
@tanstack/vue-query 70.60% <ø> (ø)
@tanstack/vue-query-devtools ∅ <ø> (∅)

@lachlancollins lachlancollins merged commit 15e42ba into main Jun 25, 2024
@lachlancollins lachlancollins deleted the ts-v4-tests branch June 25, 2024 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment