Skip to content

Conversation

@crutchcorn
Copy link
Member

This PR refactors the existing implementations of NotifyManager and Subscribable instances into TanStack Store utilities as an experiment to see if we're able to consolidate on the tooling we want to use for our projects.

This is a WIP and experiment; this may not ultimately yield any changes to Query.

@vercel
Copy link

vercel bot commented Jan 31, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated (UTC)
query ⬜️ Ignored (Inspect) Jan 31, 2024 9:54am

@nx-cloud
Copy link

nx-cloud bot commented Jan 31, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 9867964. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


🟥 Failed Commands
nx affected --targets=test:eslint,test:lib,test:types,test:build,build --exclude=examples/**

Sent with 💌 from NxCloud.

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 9867964:

Sandbox Source
@tanstack/query-example-angular-basic Configuration
@tanstack/query-example-react-basic-typescript Configuration
@tanstack/query-example-solid-basic-typescript Configuration
@tanstack/query-example-svelte-basic Configuration
@tanstack/query-example-vue-basic Configuration

@TkDodo
Copy link
Collaborator

TkDodo commented Feb 3, 2024

looks good, but the failing tests uses the focusManager, so I think we'd need to look into this

@TkDodo
Copy link
Collaborator

TkDodo commented Feb 3, 2024

looking at the preview build, onlineManager seems to work fine, but focusManager does not - I can't get window focus refetching to work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants