Skip to content

fix(types): improve v2 types #655

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tannerlinsley merged 2 commits into from
Jun 29, 2020
Merged

fix(types): improve v2 types #655

tannerlinsley merged 2 commits into from
Jun 29, 2020

Conversation

@jelteliekens
Copy link
Contributor

@jelteliekens jelteliekens commented Jun 29, 2020

  • Fix missing argument variables in onError and onSettled in the mutation options.
  • Add generic TSnapshot for snapshot value so the correct type is available in onError and onSettled.
  • Add generic TResult in BaseQueryOptions which removes the need of using any in onSuccess and onSettled.

@smashercosmo smashercosmo mentioned this pull request Jun 29, 2020
Closed
@tannerlinsley tannerlinsley merged commit bb3535d into TanStack:master Jun 29, 2020
@tannerlinsley
Copy link
Member

tannerlinsley commented Jun 29, 2020

🎉 This PR is included in version 2.4.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MichaelDeBoey MichaelDeBoey MichaelDeBoey approved these changes

Assignees

No one assigned

Labels

released

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jelteliekens @tannerlinsley @MichaelDeBoey