Skip to content

Conversation

@wolverineks
Copy link
Contributor

adds more files to formatting,
other options:

  • add precommit hook to format
  • combine eslint + prettier

@wolverineks wolverineks changed the title Formatting (style): Formatting Jun 28, 2020
@wolverineks wolverineks changed the title (style): Formatting (style): formatting Jun 28, 2020
Copy link
Member

@tannerlinsley tannerlinsley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be enabled && (documentIsVisible || refetchIntervalInBackground)

@wolverineks
Copy link
Contributor Author

This needs to be enabled && (documentIsVisible || refetchIntervalInBackground)

prettier makes the claim that it doesnt change the ast of the code,
this is the way the code was going to execute anyway

if you want i can fix this in a different pr?
especially as this doesnt fail any tests

@tannerlinsley
Copy link
Member

Right, it didn’t change it here. It was just bad to start. :)

@wolverineks
Copy link
Contributor Author

if you want to make the code suggestion ill accept it

@tannerlinsley
Copy link
Member

I already fixed in a separate Commit :)

@tannerlinsley tannerlinsley merged commit ac11bdc into TanStack:master Jun 28, 2020
@wolverineks wolverineks deleted the formatting branch June 28, 2020 21:24
@tannerlinsley
Copy link
Member

🎉 This PR is included in version 2.4.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants