Skip to content

fix: edge case when refetching infinite query #409

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tannerlinsley merged 1 commit into from
Apr 26, 2020
Merged

fix: edge case when refetching infinite query #409

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions src/useInfiniteQuery.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,11 +28,20 @@ export function useInfiniteQuery(...args) {
data.push(await originalQueryFn(...args))
rebuiltPageVariables.push(args)
} else {
// get an up-to-date cursor based on the previous data set
const nextCursor = getGetFetchMore()(data[data.length - 1], data);

// break early if there's no next cursor
// otherwise we'll start from the beginning
// which will cause unwanted duplication
if (!nextCursor) {
break;
}

const pageArgs = [
// remove the last argument (the previously saved cursor)
...args.slice(0, -1),
// generate an up-to-date cursor based on the previous data set
getGetFetchMore()(data[data.length - 1], data),
nextCursor
]

data.push(await originalQueryFn(...pageArgs))
Expand Down