-
-
Notifications
You must be signed in to change notification settings - Fork 3.3k
feat(devtools): add timeline (draft) #3881
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit ad2ea78:
|
If someone has some feedback on how to add horizontal scrolling and zooming (I am not convinced with the current solution for zooming), it will be very appreciated :) |
I don't feel very confident to merge this one in one piece given the scope of changes required:
Going forward I think the best approach would be:
1 and 2 could be done in one shot, but I don't want to put too much cognitive load on both myself and reviewers :-). @TkDodo what do you think about this? |
this sounds like a good idea. Maybe we should merge this one first though? |
Yes indeed :). Would be best to avoid rework on related PRs. |
I'll try to get that one over the finish line this week. Let's close this PR ? |
Yes, I will create related PRs when #4352 is merged. |
devtools have been re-written in solid and now work for all framework adapters. |
Clone of #3841 at is was easier to start from scratch after the v4 merge (closing the other one as a result).
This is to add a timeline in the chrome devtools as discussed here: #3753
Screenshot below of the current state of work:
TODO