Repository navigation
Feature/persist error handling - #3556
Merged
Merged
Conversation
only used for the Promisable type, which is easy to recreate
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 4980f5b:
|
Codecov Report
@@ Coverage Diff @@
## beta #3556 +/- ##
==========================================
+ Coverage 96.93% 97.10% +0.17%
==========================================
Files 48 49 +1
Lines 2383 2387 +4
Branches 709 709
==========================================
+ Hits 2310 2318 +8
+ Misses 71 67 -4
Partials 2 2
Continue to review full report at Codecov.
|
…t-error-handling # Conflicts: # src/createWebStoragePersister/tests/storageIsFull.test.ts
if null is returned, which is also the default strategy, the webstorage entry will be removed completely.
TkDodo
marked this pull request as ready for review
May 15, 2022 07:20
to make sync and async compatible, persist version must also throw an error to abort
Member
|
🎉 This PR is included in version 4.0.0-beta.13 🎉 The release is available on: Your semantic-release bot 📦🚀 |
m8951406
pushed a commit
to mustafakmelli/query
that referenced
this pull request
Feb 17, 2026
* refactor: remove type-fest as a dependency only used for the Promisable type, which is easy to recreate * feat(persistQueryClient): error handling strategies for persist plugins * feat(persistQueryClient): error handling strategies for persist plugins adapt tests * make handlePersistError return null to stop retries if null is returned, which is also the default strategy, the webstorage entry will be removed completely. * test for default behaviour * async version for persist error handling to make sync and async compatible, persist version must also throw an error to abort * make sure that async persister can accept sync error handlers * undefined errorStrategy, or return undefined from it, will just not persist anymore * rename to retry + documentation * improve docs
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #3034