test that Suspense mode calls queryFn only once #325
Merged
+33
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simoncarpinter
commented
Apr 6, 2020
| cleanup() | ||
| }) | ||
|
|
||
| it('should not call the queryFn twice when used in Suspense mode', async () => { |
Contributor
Author
There was a problem hiding this comment.
can remove the "when used in Suspense mode" bit, woops.
Suggested change
| it('should not call the queryFn twice when used in Suspense mode', async () => { | |
| it('should not call the queryFn twice', async () => { |
|
View your CI Pipeline Execution ↗ for commit cc09457
☁️ Nx Cloud last updated this comment at |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #324 -- this adds some test coverage. I'd like to fix the bug too, but haven't yet spotted where it's lurking.