Skip to content

feat: meta to Mutation - #2906

Merged
TkDodo merged 6 commits into
TanStack:masterfrom
danielbartsch:meta-to-useMutation
Nov 17, 2021
Merged

TkDodo merged 6 commits into
TanStack:masterfrom
danielbartsch:meta-to-useMutation

Conversation

@danielbartsch

Copy link
Copy Markdown
Contributor

the same meta that already exists in Query and is accessible in
queryCache is now also usable in mutationCache and can be passed in
useMutation, just as in useQuery

Context: TkDodo/blog-comments#29 (comment)

the same meta that already exists in Query and is accessible in
queryCache is now also usable in mutationCache and can be passed in
useMutation, just as in useQuery
@vercel

vercel Bot commented Nov 9, 2021 •

Copy link
Copy Markdown

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/tanstack/react-query/Y4AKnKDuFACteo5PhSeWuePB7N9d
✅ Preview: https://react-query-git-fork-danielbartsch-meta-to-usemutation-tanstack.vercel.app

@codesandbox-ci

codesandbox-ci Bot commented Nov 9, 2021 •

Copy link
Copy Markdown

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit b464b49:

Sandbox Source
tannerlinsley/react-query: basic Configuration
tannerlinsley/react-query: basic-typescript Configuration

@codecov

codecov Bot commented Nov 9, 2021 •

Copy link
Copy Markdown

Codecov Report

Merging #2906 (b464b49) into master (c118513) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2906   +/-   ##
=======================================
  Coverage   96.40%   96.40%           
=======================================
  Files          45       45           
  Lines        2226     2228    +2     
  Branches      636      637    +1     
=======================================
+ Hits         2146     2148    +2     
  Misses         77       77           
  Partials        3        3           
Impacted Files Coverage Δ
src/core/mutationCache.ts 100.00% <ø> (ø)
src/core/mutation.ts 100.00% <100.00%> (ø)
src/react/useBaseQuery.ts 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c118513...b464b49. Read the comment docs.

@TkDodo TkDodo left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very good work, thank you 🚀

Comment thread src/react/tests/useMutation.test.tsx Outdated
Comment thread src/core/mutation.ts Outdated
Reason: #2906 (comment)

Co-authored-by: Dominik Dorfmeister <office@dorfmeister.cc>

@TkDodo TkDodo left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I totally missed that we also need to update the documentation please

@danielbartsch

Copy link
Copy Markdown
Contributor Author

b464b49
I hope this is fine

@TkDodo
TkDodo merged commit 5285479 into TanStack:master Nov 17, 2021
@tannerlinsley

Copy link
Copy Markdown
Member

🎉 This PR is included in version 3.33.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

This branch was successfully deployed

1 active deployment
Preview — b464b495 Deployed Nov 17, 2021 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants