Skip to content

fix(test): devtools sort queries test fails on Apple Silicon M1 pro #2832

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TkDodo merged 2 commits into from
Oct 27, 2021
Merged

fix(test): devtools sort queries test fails on Apple Silicon M1 pro #2832

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
24e9675
fix(test): devtools sort queries test on apple silicon
arnaudbzn Oct 26, 2021
d2b2cf5
test(devtools): add a sleep to wait for the queries to be resolved
arnaudbzn Oct 27, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion src/devtools/tests/devtools.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -345,6 +345,7 @@ describe('ReactQueryDevtools', () => {
// When sorted by query hash the queries get sorted according
// to just the number, with the order being -> query-1, query-2, query-3
fireEvent.change(sortSelect, { target: { value: 'Query Hash' } })

/** To check the order of the queries we can use regex to find
* all the row items in an array and then compare the items
* one by one in the order we expect it
Expand All @@ -355,10 +356,14 @@ describe('ReactQueryDevtools', () => {
expect(queries[1]?.textContent).toEqual(query2Hash)
expect(queries[2]?.textContent).toEqual(query3Hash)

// Wait for the queries to be resolved
await sleep(70)

// When sorted by the last updated date the queries are sorted by the time
// they were updated and since the query-2 takes longest time to complete
// and query-1 the shortest, so the order is -> query-2, query-3, query-1
fireEvent.change(sortSelect, { target: { value: 'Last Updated' } })

queries = await screen.findAllByText(/\["query-[1-3]"\]/)
expect(queries[0]?.textContent).toEqual(query2Hash)
expect(queries[1]?.textContent).toEqual(query3Hash)
Expand All @@ -368,7 +373,10 @@ describe('ReactQueryDevtools', () => {
// query-3 takes precedence because its stale time being infinity, it
// always remains fresh, the rest of the queries are sorted by their last
// updated time, so the resulting order is -> query-3, query-2, query-1
fireEvent.change(sortSelect, { target: { value: 'Status > Last Updated' } })
fireEvent.change(sortSelect, {
target: { value: 'Status > Last Updated' },
})

queries = await screen.findAllByText(/\["query-[1-3]"\]/)
expect(queries[0]?.textContent).toEqual(query3Hash)
expect(queries[1]?.textContent).toEqual(query2Hash)
Expand All @@ -377,6 +385,7 @@ describe('ReactQueryDevtools', () => {
// Switch the order form ascending to descending and expect the
// query order to be reversed from previous state
fireEvent.click(screen.getByRole('button', { name: /⬆ asc/i }))

queries = await screen.findAllByText(/\["query-[1-3]"\]/)
expect(queries[0]?.textContent).toEqual(query1Hash)
expect(queries[1]?.textContent).toEqual(query2Hash)
Expand Down