Return Statement #2713
Merged
Return Statement #2713
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I know everyone loves the one-liner code. It looks awesome!
But in this certain case, I thought newTodo is the second argument to useMutation hook which was very confusing for me when I tried to code and it didn't work. It took me a very long time to notice that small detail.
I I think the return statement will drastically remove that confusion. `useMutation(newTodo => axios.post('/todos', newTodo))`
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/tannerlinsley/react-query/Cq98NAumhvGbfeQr6YML35691sgt |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 7ad3678:
|
Contributor
Author
|
|
|
Yes
…On Fri, 24 Sep 2021, 3:16 am Noorullah Ahmadzai, ***@***.***> wrote:
Before:
[image: Screen Capture_select-area_20210924015932]
<https://user-images.githubusercontent.com/28804764/134586805-e7adcee4-bd6c-48c2-a02c-f7621cf45a92.png>
After:
[image: Screen Capture_select-area_20210924015849]
<https://user-images.githubusercontent.com/28804764/134586824-0b09a33b-9061-483c-a3a4-4158f558ac3b.png>
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#2713 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AL4TYELWSIUIYOGQP2V3GTTUDOMCDANCNFSM5EUSE2QQ>
.
|
Member
|
🎉 This PR is included in version 3.24.5 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Return Statement
I know everyone loves the one-liner code. It looks awesome!
But in this certain case, I thought newTodo is the second argument to useMutation hook here
useMutation(newTodo => axios.post('/todos', newTodo))which was very confusing for me when I tried to code and it didn't work. It took me a very long time to notice that small detail.I think the return statement will drastically remove that confusion.