Skip to content

fix(useQuery): streamline parameters passed to useErrorBoundary function to be the same as onError of the queryCache #2660

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 20, 2022
Merged

fix(useQuery): streamline parameters passed to useErrorBoundary function to be the same as onError of the queryCache #2660

merged 2 commits into from
Feb 20, 2022

Conversation

TkDodo
Copy link
Collaborator

@TkDodo TkDodo commented Sep 10, 2021

No description provided.

@TkDodo
fix(useQuery): streamline parameters passed to useErrorBoundary funct…
4c987e1 
…ion to be the same as onError of the queryCache
@vercel
Copy link

vercel bot commented Sep 10, 2021 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/tanstack/react-query/2EXE8Qy7nHh2tGBKsCep51NzC2Hk
✅ Preview: https://react-query-git-fork-tkdodo-feature-fix-useerro-f1eb4a-tanstack.vercel.app

@codesandbox-ci
Copy link

codesandbox-ci bot commented Sep 10, 2021 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 1f73f35:

Sandbox Source
tannerlinsley/react-query: basic Configuration
tannerlinsley/react-query: basic-typescript Configuration

@TkDodo
Merge remote-tracking branch 'react-query/master' into feature/fix-us…
1f73f35 
…eErrorBoundary-params

# Conflicts:
#	docs/src/pages/reference/useQuery.md
#	src/core/types.ts
@codecov
Copy link

codecov bot commented Feb 20, 2022

Codecov Report

Merging #2660 (1f73f35) into master (eb4e863) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2660   +/-   ##
=======================================
  Coverage   96.47%   96.47%           
=======================================
  Files          45       45           
  Lines        2271     2271           
  Branches      639      639           
=======================================
  Hits         2191     2191           
  Misses         77       77           
  Partials        3        3
Impacted Files Coverage Δ
src/react/useBaseQuery.ts 100.00% <ø> (ø)
src/react/useMutation.ts 100.00% <100.00%> (ø)
src/react/utils.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eb4e863...1f73f35. Read the comment docs.

@TkDodo TkDodo merged commit b44c213 into TanStack:master Feb 20, 2022
@TkDodo TkDodo deleted the feature/fix-useErrorBoundary-params branch February 20, 2022 13:09
@tannerlinsley
Copy link
Collaborator

🎉 This PR is included in version 3.34.16 🎉

The release is available on:

Your semantic-release bot 📦🚀

@tannerlinsley
Copy link
Collaborator

🎉 This PR is included in version 4.0.0-alpha.14 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
released on @alpha released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TkDodo @tannerlinsley