fix(types): fix generics for refetchPage function #2638
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
two issues: 1) The types inferred for the `refetch` function returned from useInfiniteQuery were wrong, as the input to the function is not of type InfiniteData; It's quite hard to infer the correct type, so making the function generic and defaulting to unknown is the safer choice. Users can now still explicitly provide the generic. 2) for all other methods on the queryClient, generics were mising and types for pages / allPages were always unknown. Adding a generic to refetchQueries / invalidateQueries / resetQueries that also defaults to unknown fixes that and makes those function easier to work with
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/tannerlinsley/react-query/2SpSDFPaq3uQBw4R2DCm1UE7CwaV |
Member
|
🎉 This PR is included in version 3.24.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
two issues:
The types inferred for the
refetchfunction returned from useInfiniteQuery were wrong, as the input to the function is not of type InfiniteData; It's quite hard to infer the correct type, so making the function generic and defaulting to unknown is the safer choice. Users can now still explicitly provide the generic.for all other methods on the queryClient, generics were mising and types for pages / allPages were always unknown. Adding a generic to refetchQueries / invalidateQueries / resetQueries that also defaults to unknown fixes that and makes those function easier to work with