feat(useQuery): make refetchInterval accept a function #2622
Conversation
so that we can have intervals dependent on current data / error
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/tannerlinsley/react-query/CpE3rkSfacdTniSc2taTcuhiexU9 |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 5014265:
|
add a test for refetch interval function
treat refetchInterval of 0 the same as false (no interval)
pass the whole query as second argument to refetchInterval function. errors can still be accessed via `query.state.error`, and it will give us access to the queryKey as well (useful for setting up the interval globally in defaultOptions). separating out `data` as separate parameter still makes sense because it will be the observer result (possibly transformed by `select`), while `query.state.data` will be the raw data
always pass nextInterval to updateRefetchInterval
use false as a fallback instead of zero
|
🎉 This PR is included in version 3.25.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
There was a problem hiding this comment.
I know a few years have passed and it's too late to say this, but using refetchInterval means using setInterval and it means it is short-polling not a long-polling.
The long-polling uses the Promise answer to set the next call, and it seems RQ hasn't received it yet.
cc: @TkDodo
3 participants
so that we can have intervals dependent on current data / error