-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
test(devtools): Add base tests for react-query devtools #2433
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Add the basic test for opening and closing devtools
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/tannerlinsley/react-query/8T4j6pggo6RHgTseoXcuSjke6SwC |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit cdccd3c:
|
|
@TkDodo @tannerlinsley Just adding a comment here to make sure you didn't miss this PR 😬. Also, do let me know if I should squash the commits. |
TkDodo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good work, thank you 💪. Just a couple of small comments from my side please:
|
@TkDodo Let me know if anything else is pending here. |
|
🎉 This PR is included in version 3.19.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
updatedAtinstead ofdataUpdatedAt)Fixes #2371