Skip to content

Conversation

@prateek3255
Copy link
Contributor

@prateek3255 prateek3255 commented Jul 4, 2021

  • ✅. Added the following tests for devtools (except query details explorer)
    • Opening and closing the devtools panel
    • Displaying the correct states for queries
    • Displaying all the query hash in the rows and opening the query details explorer upon clicking it
    • Searching the queries
    • Sorting the queries via different sorting filters available
  • ♿️ Added accessibility labels to buttons and inputs, which not only helped in writing good tests but also improved the overall accessibility of devtools
  • 🐛. Fixed a bug that sorted queries incorrectly. While adding the test cases for sorting queries, I found that the sorting was not working as expected because of an incorrect key name being used (updatedAt instead of dataUpdatedAt)

Fixes #2371

@vercel
Copy link

vercel bot commented Jul 4, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/tannerlinsley/react-query/8T4j6pggo6RHgTseoXcuSjke6SwC
✅ Preview: https://react-query-git-fork-prateek3255-test-devtools-tannerlinsley.vercel.app

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jul 4, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit cdccd3c:

Sandbox Source
tannerlinsley/react-query: basic Configuration
tannerlinsley/react-query: basic-typescript Configuration

@prateek3255
Copy link
Contributor Author

@TkDodo @tannerlinsley Just adding a comment here to make sure you didn't miss this PR 😬. Also, do let me know if I should squash the commits.

Copy link
Collaborator

@TkDodo TkDodo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good work, thank you 💪. Just a couple of small comments from my side please:

@prateek3255
Copy link
Contributor Author

@TkDodo Let me know if anything else is pending here.

@TkDodo TkDodo merged commit 4b1e711 into TanStack:master Jul 16, 2021
@prateek3255 prateek3255 deleted the test/devtools branch July 16, 2021 17:38
@tannerlinsley
Copy link
Member

🎉 This PR is included in version 3.19.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add tests for react-query devtools

3 participants