fix: rename asyncStoragePersistor to createAsyncStoragePersistor

[brunohkbx]

Why

This function was being called as createAsyncStoragePersistor in the docs but was exported as asyncStoragePersistor

[vercel]

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/tannerlinsley/react-query/E112qQPJE58PRU6NxUbZVBqLY6jy
✅ Preview: https://react-query-git-fork-brunohkbx-fix-rename-f27c13-tannerlinsley.vercel.app

[codesandbox-ci]

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 4575bba:

Sandbox	Source
tannerlinsley/react-query: basic	Configuration
tannerlinsley/react-query: basic-typescript	Configuration

[Aung-Myint-Thein]

Yes, I found out that just today and also asyncStorageKey storage persistor options is just key in the codes. So, might need to fix the doc or fix the codes. I think changing the doc is easier approach but the overall naming will be a bit off. Any take on this?

[maylinmedina]

I found another issue. The storage parameter in CreateAsyncStoragePersistorOptions has AsyncStorage type, but the AsyncStorage object imported from @react-native-async-storage/async-storage has AsyncStorageStatic type, so there is an incompatibility when building the persistor by following the documentation:

import AsyncStorage from '@react-native-async-storage/async-storage';
import { createAsyncStoragePersistor } from 'react-query/createAsyncStoragePersistor-experimental';

const asyncStoragePersistor = createAsyncStoragePersistor({
  storage: AsyncStorage,
});

[brunohkbx]

Thanks @Aung-Myint-Thein @maylinmedina for pointing it out. I think it should be good now. can you guys take a look again?

[maylinmedina]

@brunohkbx Looks good to me. Thanks.

[bombillazo]

I'm eagerly awaiting these changes :D wanna test it out in my build.

[Aung-Myint-Thein]

I'm eagerly awaiting these changes :D wanna test it out in my build.

Oh you can actually test out this in the codes. The discussion here is just for naming consistency :D Please let us know where you have problems and I can help out.

[tannerlinsley]

🎉 This PR is included in version 3.19.0 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀