Update paginated-queries.md #2345
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`query.data` is always `undefined` at initial render; because of this the `data.hasMore` check in the "Next Page" button throws a type error when this mini-app launches(`TypeError: Cannot read property 'hasMore' of undefined`) and crashes the whole thing. I'm using javascript optional chaning to check if there is a data object before accessing the `hasMore` property - this fixes the type error and the mini-app works fine.
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/tannerlinsley/react-query/HB47yaYkiDDcHrMHfgudtAKWn5p9 |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit efa41e9:
|
Member
|
🎉 This PR is included in version 3.17.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ISSUE:
query.datais alwaysundefinedat initial render; because of this thedata.hasMorecheck in the "Next Page" button throws a type error(TypeError: Cannot read property 'hasMore' of undefined) and crashes the whole thing on app launch.FIX:
I'm using javascript optional chaining to check if there is a data object before accessing the
hasMoreproperty - this fixes the type error and the code works fine.