Skip to content

fix(devtools): fix devtools crash on rejected promises on refetch #2344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TkDodo merged 1 commit into from
Jun 5, 2021
Merged

fix(devtools): fix devtools crash on rejected promises on refetch #2344

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion src/devtools/devtools.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ import { ThemeProvider, defaultTheme as theme } from './theme'
import { getQueryStatusLabel, getQueryStatusColor } from './utils'
import Explorer from './Explorer'
import Logo from './Logo'
import { noop } from '../core/utils'

interface DevtoolsOptions {
/**
Expand Down Expand Up @@ -384,6 +385,11 @@ export const ReactQueryDevtoolsPanel = React.forwardRef(
return undefined
}, [isOpen, sort, sortFn, sortDesc, setUnsortedQueries, queryCache])

const handleRefetch = () => {
const promise = activeQuery.fetch()
promise.catch(noop)
}

return (
<ThemeProvider theme={theme}>
<Panel
Expand Down Expand Up @@ -710,7 +716,7 @@ export const ReactQueryDevtoolsPanel = React.forwardRef(
>
<Button
type="button"
onClick={() => activeQuery.fetch()}
onClick={handleRefetch}
disabled={activeQuery.state.isFetching}
style={{
background: theme.active,
Expand Down