Skip to content

chore: add prettier to pipeline checks and include .ts files - #2205

Merged
TkDodo merged 13 commits into
TanStack:masterfrom
TkDodo:feature/prettier
Apr 29, 2021
Merged

TkDodo merged 13 commits into
TanStack:masterfrom
TkDodo:feature/prettier

Conversation

@TkDodo

@TkDodo TkDodo commented Apr 28, 2021

Copy link
Copy Markdown
Collaborator

No description provided.

@vercel

vercel Bot commented Apr 28, 2021 •

Copy link
Copy Markdown

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/tannerlinsley/react-query/Efd49t4TsGwFYBNTY69b6ZE4Dpkk
✅ Preview: https://react-query-git-fork-tkdodo-feature-prettier-tannerlinsley.vercel.app

@codesandbox-ci

codesandbox-ci Bot commented Apr 28, 2021 •

Copy link
Copy Markdown

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 5e5b8c9:

Sandbox Source
tannerlinsley/react-query: basic Configuration
tannerlinsley/react-query: basic-typescript Configuration

@TkDodo

TkDodo commented Apr 28, 2021

Copy link
Copy Markdown
Collaborator Author

Checking formatting...
[warn] src/core/focusManager.ts
[warn] Code style issues found in the above file(s). Forgot to run Prettier?

I ran prettier a million times locally - not sure what I'm doing wrong, but the checks pass locally for me. Anything I'm missing?

add debug log level to see what is going on in CI
@TkDodo

TkDodo commented Apr 28, 2021

Copy link
Copy Markdown
Collaborator Author

I ran prettier a million times locally - not sure what I'm doing wrong, but the checks pass locally for me. Anything I'm missing?

figured it out. my fork wasn't up-to-date 🤦

@TkDodo
TkDodo merged commit 9686426 into TanStack:master Apr 29, 2021
@TkDodo
TkDodo deleted the feature/prettier branch April 29, 2021 19:55
@tannerlinsley

Copy link
Copy Markdown
Member

🎉 This PR is included in version 3.15.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

This branch was successfully deployed

1 active deployment
Preview — 5e5b8c9b Deployed Apr 29, 2021 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants