Skip to content

fix(types): allow returning of any promise in the mutation callbacks - #2189

Merged
tannerlinsley merged 4 commits into
TanStack:masterfrom
TkDodo:feature/2166
Apr 28, 2021
Merged

tannerlinsley merged 4 commits into
TanStack:masterfrom
TkDodo:feature/2166

Conversation

@TkDodo

@TkDodo TkDodo commented Apr 24, 2021

Copy link
Copy Markdown
Collaborator

closes #2166

@vercel

vercel Bot commented Apr 24, 2021 •

Copy link
Copy Markdown

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/tannerlinsley/react-query/55TXa8m5Q6AXdpoeNB9zn7fnr3Cd
✅ Preview: https://react-query-git-fork-tkdodo-feature-2166-tannerlinsley.vercel.app

@codesandbox-ci

Copy link
Copy Markdown

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 49b5207:

Sandbox Source
tannerlinsley/react-query: basic Configuration
tannerlinsley/react-query: basic-typescript Configuration

@TkDodo
TkDodo requested a review from tannerlinsley April 28, 2021 17:49
@tannerlinsley
tannerlinsley merged commit 2e03a61 into TanStack:master Apr 28, 2021
@tannerlinsley

Copy link
Copy Markdown
Member

🎉 This PR is included in version 3.15.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@TkDodo
TkDodo deleted the feature/2166 branch April 29, 2021 07:51

This branch was successfully deployed

1 active deployment
Preview — 49b5207c Deployed Apr 24, 2021 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

overly restrictive return typing for onSuccess handler

2 participants