Skip to content

Conversation

@luisadame
Copy link
Contributor

Description

In version 2 the QueryStatus typing was:

export enum QueryStatus {
  Idle = 'idle',
  Loading = 'loading',
  Error = 'error',
  Success = 'success',
}

https://github.com/tannerlinsley/react-query/blame/8aeb209c3b9c84382a88059afbc398be93a69b33/src/core/types.ts#L183

And now in version 3 is:

export type QueryStatus = 'idle' | 'loading' | 'error' | 'success'

https://github.com/tannerlinsley/react-query/blame/7b14ef519a544d725f2cff99574f0a01f92b8c94/src/core/types.ts#L257

Changes

  • documented the change described above
  • added underline to links that are children of headings
    image
    image
    this affects anchor links but these already have an underline property set, so I think there's no issue with that

as their color is inherited from the heading and links are
indistinguishable from the heading itself
@vercel
Copy link

vercel bot commented Apr 2, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/tannerlinsley/react-query/EcuFzgJb6pcjJ5AzRW2auuAZmQTx
✅ Preview: https://react-query-git-fork-luisadame-docs-query-status-tannerlinsley.vercel.app

@codesandbox-ci
Copy link

codesandbox-ci bot commented Apr 2, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit b98b18c:

Sandbox Source
tannerlinsley/react-query: basic Configuration
tannerlinsley/react-query: basic-typescript Configuration

@TkDodo TkDodo merged commit e81cb47 into TanStack:master Apr 3, 2021
@luisadame luisadame deleted the docs/query-status branch April 3, 2021 17:11
@tannerlinsley
Copy link
Member

🎉 This PR is included in version 3.13.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants