fix(types): onlineManager: setup function needs to accept the online boolean, and the cleanup function shouldn't #2053
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e cleanup function shouldn't
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/tannerlinsley/react-query/37BwGWe26RznyruNcUFZC62Y3paW |
Member
|
🎉 This PR is included in version 3.13.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
fmauquie
added a commit
to fmauquie/react-query
that referenced
this pull request
Apr 20, 2021
Typings did not allow passing a function taking `setFocused` to addEventListener Fixing by using the same typings as in `onlineManager.ts`, same behavior as set in TanStack#2053
TkDodo
pushed a commit
that referenced
this pull request
Apr 24, 2021
Typings did not allow passing a function taking `setFocused` to addEventListener Fixing by using the same typings as in `onlineManager.ts`, same behavior as set in #2053
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2048