Prefer ReadonlyArray for query keys #1854
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since keys are treated as readonly anway, this allows users to use `as const` without nasty surprises.
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/tannerlinsley/react-query/6VpDtXcKY8mc1vnRF1QuJpDmVtdH |
TkDodo
reviewed
Feb 23, 2021
TkDodo
approved these changes
Feb 23, 2021
tannerlinsley
approved these changes
Feb 23, 2021
Contributor
Author
|
@tannerlinsley Do I need to do anything for this to be merged? |
Member
|
🎉 This PR is included in version 3.12.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This was referenced Mar 9, 2021
This was referenced Mar 16, 2021
This was referenced Mar 18, 2021
pascalduez
pushed a commit
to flow-typed/flow-typed
that referenced
this pull request
Mar 23, 2021
* Infer data type from query function instead of reverse. See TanStack/query#1470 * Default generics to mixed like TypeScript does with unknown * Use $ReadOnlyArray for query keys. See TanStack/query#1854 * Remove impossible null states (void | T instead of ?T) * Attempt to fix infinite query types * Export all types
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mutable arrays can be passed to functions expecting readonly arrays but readonly arrays can't be passed to functions expecting mutable arrays. Since
react-querydoesn't actually mutate query keys, it should use the more permissiveReadonlyArrayforQueryKey(andMutationKey) instead.This allows users to do things like this without having to strip
readonlyfrom the inferred types: