Feature/error for retry delay #1838
Conversation
this streamlines the interfaces of retry and retryDelay functions
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/tannerlinsley/react-query/E4fbcy2cytA3euVCYXTetESubwa2 |
| const delay = functionalUpdate(retryDelay, this.failureCount) || 0 | ||
| const delay = | ||
| typeof retryDelay === 'function' | ||
| ? retryDelay(this.failureCount, error) | ||
| : retryDelay |
There was a problem hiding this comment.
I am not sure why || 0 was needed here before. On type level, the function was only allowed to return a number, and we also use the defaultRetryDelay in case retryDelay was undefined
tannerlinsley
left a comment
tannerlinsley
left a comment
There was a problem hiding this comment.
Looks great! Derk will be happy about this one.
|
Oooooh yeah! I only have praise. Thanks @TkDodo! |
|
Can we merge this? |
|
🎉 This PR is included in version 3.12.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
3 participants
pass error as second parameter to retryDelay function
this streamlines the interfaces of
retryandretryDelayfunctions.One use-case would be to have a retry that depends on the
Retry-Afterheader sent from the backend, see also: https://twitter.com/SleeplessByte/status/1362946642513719296