refactor(QueryClientProvider): validation for context being overwritten #1804
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/tannerlinsley/react-query/aqfh4ceuo |
Collaborator
|
Please have a look at this issue: #1764 i fear this PR might worsen the situation if you mount two independent microfrontends, since the second one will just get the Error :/ |
Member
|
I’m working on a fix for all of this right now. Stay tuned.
Tanner Linsley
…On Feb 15, 2021, 11:34 AM -0700, Dominik Dorfmeister ***@***.***>, wrote:
Please have a look at this issue: #1764
i fear this PR might worsen the situation if you mount two independent microfrontends, since the second one will just get the Error :/
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
Member
|
I've got a separate fix which also addresses a few other related concerns in #1805 |
Author
|
Awesome. Cheers @tannerlinsley 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had an issue within our application which basically meant we were overwriting our
ReactQueryClientContextwith the default because of some unexpected rerendering. This meant even having set<QueryClientProvider>at basically root we were still getting the errorNo Query set...error. I think it would be great to supply a correct error message in this scenario as I'm sure I won't be the only one to come across this in the future.First time contributing here, let me know if I need to change anything :)