Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions src/core/queriesObserver.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { difference, getQueryKeyHashFn, replaceAt } from './utils'
import { difference, replaceAt } from './utils'
import { notifyManager } from './notifyManager'
import type { QueryObserverOptions, QueryObserverResult } from './types'
import type { QueryClient } from './queryClient'
Expand Down Expand Up @@ -63,8 +63,6 @@ export class QueriesObserver extends Subscribable<QueriesObserverListener> {
let observer: QueryObserver | undefined = this.observers[i]

const defaultedOptions = this.client.defaultQueryObserverOptions(options)
const hashFn = getQueryKeyHashFn(defaultedOptions)
defaultedOptions.queryHash = hashFn(defaultedOptions.queryKey!)

if (
!observer ||
Expand Down Expand Up @@ -94,8 +92,6 @@ export class QueriesObserver extends Subscribable<QueriesObserverListener> {
const defaultedOptions = this.client.defaultQueryObserverOptions(
options
)
const hashFn = getQueryKeyHashFn(defaultedOptions)
defaultedOptions.queryHash = hashFn(defaultedOptions.queryKey!)

if (
!observer ||
Expand Down
5 changes: 3 additions & 2 deletions src/core/queryCache.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import {
QueryFilters,
getQueryKeyHashFn,
hashQueryKeyByOptions,
matchQuery,
parseFilterArgs,
} from './utils'
Expand Down Expand Up @@ -43,7 +43,8 @@ export class QueryCache extends Subscribable<QueryCacheListener> {
state?: QueryState<TData, TError>
): Query<TQueryFnData, TError, TData> {
const queryKey = options.queryKey!
const queryHash = options.queryHash ?? getQueryKeyHashFn(options)(queryKey)
const queryHash =
options.queryHash ?? hashQueryKeyByOptions(queryKey, options)
let query = this.get<TQueryFnData, TError, TData>(queryHash)

if (!query) {
Expand Down
7 changes: 4 additions & 3 deletions src/core/queryClient.ts
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import {
parseFilterArgs,
parseQueryArgs,
partialMatchKey,
getQueryKeyHashFn,
hashQueryKeyByOptions,
} from './utils'
import type {
DefaultOptions,
Expand Down Expand Up @@ -456,8 +456,9 @@ export class QueryClient {
} as T

if (!defaultedOptions.queryHash && defaultedOptions.queryKey) {
defaultedOptions.queryHash = getQueryKeyHashFn(defaultedOptions)(
defaultedOptions.queryKey
defaultedOptions.queryHash = hashQueryKeyByOptions(
defaultedOptions.queryKey,
defaultedOptions
)
}

Expand Down
13 changes: 13 additions & 0 deletions src/core/tests/queryClient.test.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -140,6 +140,19 @@ describe('queryClient', () => {
expect(queryClient.getQueryData(key)).toBe('qux')
})

test('should use the same query when using similar string or array query keys', () => {
const key = queryKey()
queryClient.setQueryData(key, '1')
expect(queryClient.getQueryData(key)).toBe('1')
expect(queryClient.getQueryData([key])).toBe('1')
queryClient.setQueryData([key], '2')
expect(queryClient.getQueryData(key)).toBe('2')
expect(queryClient.getQueryData([key])).toBe('2')
queryClient.setQueryData(key, '1')
expect(queryClient.getQueryData(key)).toBe('1')
expect(queryClient.getQueryData([key])).toBe('1')
})

test('should accept an update function', () => {
const key = queryKey()

Expand Down
15 changes: 8 additions & 7 deletions src/core/utils.ts
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@ import type {
MutationOptions,
QueryFunction,
QueryKey,
QueryKeyHashFunction,
QueryOptions,
} from './types'

Expand Down Expand Up @@ -153,8 +152,7 @@ export function matchQuery(

if (isQueryKey(queryKey)) {
if (exact) {
const hashFn = getQueryKeyHashFn(query.options)
if (query.queryHash !== hashFn(queryKey)) {
if (query.queryHash !== hashQueryKeyByOptions(queryKey, query.options)) {
return false
}
} else if (!partialMatchKey(query.queryKey, queryKey)) {
Expand Down Expand Up @@ -189,17 +187,20 @@ export function matchQuery(
return true
}

export function getQueryKeyHashFn(
export function hashQueryKeyByOptions(
queryKey: QueryKey,
options?: QueryOptions<any, any>
): QueryKeyHashFunction {
return options?.queryKeyHashFn || hashQueryKey
): string {
const hashFn = options?.queryKeyHashFn || hashQueryKey
return hashFn(queryKey)
}

/**
* Default query keys hash function.
*/
export function hashQueryKey(queryKey: QueryKey): string {
return stableValueHash(queryKey)
const asArray = Array.isArray(queryKey) ? queryKey : [queryKey]
return stableValueHash(asArray)
}

/**
Expand Down