Skip to content

Conversation

@babycourageous
Copy link
Contributor

Since folks are still on v2 and asking about those docs this adds a couple front-facing spots to find them:

  1. main repo README
  2. main RQ docs nav

Screen Shot 2021-01-21 at 2 37 19 PM

@vercel
Copy link

vercel bot commented Jan 21, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/tannerlinsley/react-query/eeqafg1np
✅ Preview: https://react-query-git-fork-babycourageous-feature-v2-docs-links.tannerlinsley.vercel.app

@TkDodo
Copy link
Collaborator

TkDodo commented Jan 21, 2021

Awesome. Minor thing: it doesn’t look so good on mobile, and it’s hard to know on which docs I am because v3 is not “highlighted”:
7CEB8CBA-3326-4BE3-AA42-AB36FEC9592C

@babycourageous
Copy link
Contributor Author

babycourageous commented Jan 21, 2021

Ah - you're totally right. My initial preview wasn't small enough to catch that.

I like what Tailwind does - but would be more involved, hehe
image

What do you think of keeping NAV as originally was - but putting a line on the homepage (like I did for README) that basically says "Still on v2? Check out the v2 docs here: LINK"

@TkDodo
Copy link
Collaborator

TkDodo commented Jan 21, 2021

Yep, that sounds good

This partially reverts commit 48c40e3 - reverting docs Nav only.
@babycourageous
Copy link
Contributor Author

B4 pushing - how's this?

sm:

image

md:

image

lg:

image

@TkDodo
Copy link
Collaborator

TkDodo commented Jan 22, 2021

I'd put the link under here because now it says v2 3 times in the same sentence 😅 . Or even like this:

Still using v2? No problem! Find the v2 docs here.

@babycourageous
Copy link
Contributor Author

Went with the "Still using v2? No problem! Find the v2 docs here." option. Also - apologies for the accidental period in my commit msg. Didn't mean to do that.

@TkDodo TkDodo merged commit 813d70f into TanStack:master Jan 22, 2021
@babycourageous babycourageous deleted the feature/v2-docs-links branch January 22, 2021 18:13
@tannerlinsley
Copy link
Member

🎉 This PR is included in version 3.6.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants