Changing the new invalidate button color to have more contrast #1507
Conversation
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/tannerlinsley/react-query/6kn3retkc |
src/devtools/devtools.tsx
Outdated
| danger: '#ff0085', | ||
| active: '#006bff', | ||
| warning: '#ffb200', | ||
| warning: '#ff6200', |
There was a problem hiding this comment.
This works! However, I think we could probably just make the text black for that button like the rest of the tools.
There was a problem hiding this comment.
For All other buttons? or just for the new one,
because it is kinda off having this button with different color (inconsistent)
There was a problem hiding this comment.
Anything with the yellow background should have black text I think.
There was a problem hiding this comment.
Got it 👍🏻, What do you thing if it was moved to this place to make it more consistent 👇
There was a problem hiding this comment.
The order before was from most useful to least. What is this order inspired from?
There was a problem hiding this comment.
White text buttons then the black one
if it makes bad DX it shall remain as is
There was a problem hiding this comment.
Sorry for making this PR as long as this, i wanted to make a good one 😅
There was a problem hiding this comment.
I personally like the order as is. And no worries on the PR! These are the interactions that bring us all closer :)
|
🎉 This PR is included in version 3.5.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
2 participants
Hello it is my pleasure to help in enhancing React-Query,
the button it turned to be more of an orange but it have almost double contrast ratio