You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
refactor(examples/solid/solid-start-streaming): wrap 'userInfoQueryOpts' with 'queryOptions' - #11957
In examples/solid/solid-start-streaming, userInfoQueryOpts returns a plain object that is shared by queryClient.query in the prefetch route and useQuery in UserInfo.
Wrap it with queryOptions, so the options are type-checked where they are defined and the query key is tagged with the data type.
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 4 remain after this review.
📝 Walkthrough
Walkthrough
The Solid streaming example now uses queryOptions to wrap the options returned by userInfoQueryOpts. The query key, fetch function, and configured options remain unchanged.
Changes
Solid user info query options
Layer / File(s)
Summary
Wrap user info query options examples/solid/solid-start-streaming/src/components/user-info.tsx
userInfoQueryOpts now passes its existing query key, fetch function, and configured options to queryOptions.
This change only adds type information to the existing query options, with no change to runtime configuration. No merge-blocking risk is evident.
Pre-merge checks | 5
✅ Passed checks (5 passed)
Check name
Status
Explanation
Title check
The title clearly and concisely describes the main change: wrapping userInfoQueryOpts with queryOptions in the specified example.
Description check
The description follows the required template, explains the change and motivation, includes the checklist, and records the release impact. It also states that the example type-checks and builds.
Docstring Coverage
No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1…
Linked Issues check
Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check
Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
Commit to this branch
Create a new PR
🧪 Generate unit tests (beta)
Commit to this branch
Create a new PR
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎯 Changes
In
examples/solid/solid-start-streaming,userInfoQueryOptsreturns a plain object that is shared byqueryClient.queryin the prefetch route anduseQueryinUserInfo.queryOptions, so the options are type-checked where they are defined and the query key is tagged with the data type.The example type-checks and builds.
✅ Checklist
pnpm run test:pr, or these tests do not apply to this pull request.🚀 Release Impact
Summary by CodeRabbit