You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
chore(nx.json): build the dependencies before 'test:eslint' - #11951
The examples are workspace packages, so they link @tanstack/eslint-plugin-query and the TanStack Query packages from packages/*. Their ESLint configs load those packages through their build/ output: the plugin itself, and the built types for typed linting. That output only exists after build. The test:eslint default only depended on ^compile, so each example had to override it with ^build in its package.json. algolia, basic-graphql-request and shadow-dom don't, so their lint could run before the plugin was built and fail with ERR_MODULE_NOT_FOUND.
Make ^build the test:eslint default in nx.json.
Remove the now redundant nx.targets["test:eslint"] overrides from basic, batching, eslint-legacy and eslint-plugin-demo.
All test:eslint projects now resolve to ^build, and nx run-many --target=test:eslint passes with the plugin's build/ removed beforehand.
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
Reviewing files that changed from the base of the PR and between e22e7c4 and 45402e1.
📒 Files selected for processing (5)
examples/react/basic/package.json
examples/react/batching/package.json
examples/react/eslint-legacy/package.json
examples/react/eslint-plugin-demo/package.json
nx.json
💤 Files with no reviewable changes (4)
examples/react/eslint-legacy/package.json
examples/react/basic/package.json
examples/react/eslint-plugin-demo/package.json
examples/react/batching/package.json
Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 3 remain after this review.
📝 Walkthrough
Walkthrough
The shared Nx test:eslint target now depends on upstream build targets instead of upstream compile targets. Four React example manifests no longer define local test:eslint target configuration.
The shared test:eslint target now depends on upstream build targets instead of upstream compile targets. The four React example manifests no longer define local test:eslint configuration.
The shared target builds the plugin outputs used by the affected examples, and the removed overrides preserve the same prerequisite. No merge-blocking risk remains.
Pre-merge checks | 5
✅ Passed checks (5 passed)
Check name
Status
Explanation
Title check
The title clearly and concisely describes the main change: building dependencies before the test:eslint target.
Description check
The description explains the motivation, lists the configuration changes, reports validation results, completes the checklist, and identifies the change as dev-only with no release impact.
Docstring Coverage
No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check
Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check
Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
Commit to this branch
Create a new PR
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎯 Changes
The examples are workspace packages, so they link
@tanstack/eslint-plugin-queryand the TanStack Query packages frompackages/*. Their ESLint configs load those packages through theirbuild/output: the plugin itself, and the built types for typed linting. That output only exists afterbuild. Thetest:eslintdefault only depended on^compile, so each example had to override it with^buildin itspackage.json.algolia,basic-graphql-requestandshadow-domdon't, so their lint could run before the plugin was built and fail withERR_MODULE_NOT_FOUND.^buildthetest:eslintdefault innx.json.nx.targets["test:eslint"]overrides frombasic,batching,eslint-legacyandeslint-plugin-demo.All
test:eslintprojects now resolve to^build, andnx run-many --target=test:eslintpasses with the plugin'sbuild/removed beforehand.✅ Checklist
pnpm run test:pr, or these tests do not apply to this pull request.🚀 Release Impact
Summary by CodeRabbit