chore(oxlint.config): load the jsdoc and vitest JS plugins only in the overrides that use them by sukvvon · Pull Request #11946 · TanStack/query

sukvvon · 2026-10-10T04:18:32Z

🎯 Changes

jsdoc-js and vitest-js were loaded for every file in the root oxlint.config.ts, but their rules are only enabled in one override each.

Move jsdoc-js into the **/src/**/*.{ts,tsx} override that enables the jsdoc rules.
Move vitest-js into the test-file override that enables vitest-js/valid-expect.
Keep import-js, cspell, @stylistic and the local plugin at the top level, since their rules are top-level.

This matches the previous ESLint config, where the jsdoc and vitest plugins were registered in the source and test blocks. test:oxlint output is the same in all 27 packages.

✅ Checklist

I have followed the steps in the Contributing guide.
I have tested code changes locally with pnpm run test:pr, or these tests do not apply to this pull request.
I have followed the AI contribution policy and fully understand the code in this pull request, including any code generated with AI assistance.

🚀 Release Impact

This change affects published code, and I have generated a changeset.
This change is docs/CI/dev-only (no release).

Summary by CodeRabbit

Chores
- Updated linting checks to apply documentation rules to source files and test rules to test files. End-user functionality is unchanged.

…e overrides that use them

changeset-bot · 2026-10-10T04:18:37Z

⚠️ No Changeset found

Latest commit: d65a293

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

nx-cloud · 2026-10-10T04:19:00Z

View your CI Pipeline Execution ↗ for commit d65a293

Command	Status	Duration	Result
`nx affected --targets=test:sherif,test:knip,tes...`	✅ Succeeded	4m 18s	View ↗
`nx run-many --target=build --exclude=examples/*...`	✅ Succeeded	38s	View ↗

☁️ Nx Cloud last updated this comment at 2026-10-10 04:24:00 UTC

github-actions · 2026-10-10T04:19:28Z

🚀 Changeset Version Preview

2 package(s) bumped directly, 23 bumped as dependents.

🟩 Patch bumps

Package	Version	Reason
`@tanstack/query-core`	5.104.1 → 5.104.2	Changeset
`@tanstack/vue-query`	5.104.1 → 5.104.2	Changeset
`@tanstack/angular-query-experimental`	5.104.1 → 5.104.2	Dependent
`@tanstack/angular-query-persist-client`	5.104.1 → 5.104.2	Dependent
`@tanstack/eslint-plugin-query`	5.104.1 → 5.104.2	Dependent
`@tanstack/lit-query`	0.2.26 → 0.2.27	Dependent
`@tanstack/preact-query`	5.104.1 → 5.104.2	Dependent
`@tanstack/preact-query-devtools`	5.104.1 → 5.104.2	Dependent
`@tanstack/preact-query-persist-client`	5.104.1 → 5.104.2	Dependent
`@tanstack/query-async-storage-persister`	5.104.1 → 5.104.2	Dependent
`@tanstack/query-broadcast-client-experimental`	5.104.1 → 5.104.2	Dependent
`@tanstack/query-devtools`	5.104.1 → 5.104.2	Dependent
`@tanstack/query-persist-client-core`	5.104.1 → 5.104.2	Dependent
`@tanstack/query-sync-storage-persister`	5.104.1 → 5.104.2	Dependent
`@tanstack/react-query`	5.104.1 → 5.104.2	Dependent
`@tanstack/react-query-devtools`	5.104.1 → 5.104.2	Dependent
`@tanstack/react-query-next-experimental`	5.104.1 → 5.104.2	Dependent
`@tanstack/react-query-persist-client`	5.104.1 → 5.104.2	Dependent
`@tanstack/solid-query`	5.104.1 → 5.104.2	Dependent
`@tanstack/solid-query-devtools`	5.104.1 → 5.104.2	Dependent
`@tanstack/solid-query-persist-client`	5.104.1 → 5.104.2	Dependent
`@tanstack/svelte-query`	6.3.1 → 6.3.2	Dependent
`@tanstack/svelte-query-devtools`	6.3.1 → 6.3.2	Dependent
`@tanstack/svelte-query-persist-client`	6.3.1 → 6.3.2	Dependent
`@tanstack/vue-query-devtools`	6.3.1 → 6.3.2	Dependent

coderabbitai · 2026-10-10T04:20:07Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository: TanStack/query/.coderabbit.yaml
Review profile: CHILL
Plan: Advanced
Run ID: 575b159e-f550-40ab-bfcf-5404f5862345

📥 Commits

Reviewing files that changed from the base of the PR and between a2e0eb2 and d65a293.

📒 Files selected for processing (1)

oxlint.config.ts

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review.

📝 Walkthrough

Walkthrough

The root Oxlint configuration no longer registers jsdoc-js and vitest-js globally. The TypeScript source override registers jsdoc-js, and the spec and test override registers vitest-js.

Changes

Oxlint plugin scoping

Layer / File(s)	Summary
Scope plugins to file overrides `oxlint.config.ts`	The root configuration removes global registrations for `jsdoc-js` and `vitest-js`. The TypeScript source override registers `jsdoc-js`, while the spec and test override registers `vitest-js`.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~8 minutes

Change: Refactor

Suggested reviewers: dogpawhat

Merge Risk: ⚪ Minimal · up to d65a2

This configuration change scopes JSDoc and Vitest plugins to the files using their rules while preserving the other lint plugins. No actionable merge risk was identified.

Pre-merge checks | 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check		The title clearly states the primary change: loading the JSDoc and Vitest plugins only in the overrides that use them.
Description check		The description explains the change and motivation, completes the checklist, reports testing, and identifies the change as development-only with no release impact.
Docstring Coverage		No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1…
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

📝 Generate docstrings

Commit to this branch
Create a new PR

🧪 Generate unit tests (beta)

Commit to this branch
Create a new PR

Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

pkg-pr-new · 2026-10-10T04:20:49Z

More templates

@tanstack/angular-query-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-experimental@11946

@tanstack/eslint-plugin-query

npm i https://pkg.pr.new/@tanstack/eslint-plugin-query@11946

@tanstack/lit-query

npm i https://pkg.pr.new/@tanstack/lit-query@11946

@tanstack/preact-query

npm i https://pkg.pr.new/@tanstack/preact-query@11946

@tanstack/preact-query-devtools

npm i https://pkg.pr.new/@tanstack/preact-query-devtools@11946

@tanstack/preact-query-persist-client

npm i https://pkg.pr.new/@tanstack/preact-query-persist-client@11946

@tanstack/query-async-storage-persister

npm i https://pkg.pr.new/@tanstack/query-async-storage-persister@11946

@tanstack/query-broadcast-client-experimental

npm i https://pkg.pr.new/@tanstack/query-broadcast-client-experimental@11946

@tanstack/query-core

npm i https://pkg.pr.new/@tanstack/query-core@11946

@tanstack/query-devtools

npm i https://pkg.pr.new/@tanstack/query-devtools@11946

@tanstack/query-persist-client-core

npm i https://pkg.pr.new/@tanstack/query-persist-client-core@11946

@tanstack/query-sync-storage-persister

npm i https://pkg.pr.new/@tanstack/query-sync-storage-persister@11946

@tanstack/react-query

npm i https://pkg.pr.new/@tanstack/react-query@11946

@tanstack/react-query-devtools

npm i https://pkg.pr.new/@tanstack/react-query-devtools@11946

@tanstack/react-query-next-experimental

npm i https://pkg.pr.new/@tanstack/react-query-next-experimental@11946

@tanstack/react-query-persist-client

npm i https://pkg.pr.new/@tanstack/react-query-persist-client@11946

@tanstack/solid-query

npm i https://pkg.pr.new/@tanstack/solid-query@11946

@tanstack/solid-query-devtools

npm i https://pkg.pr.new/@tanstack/solid-query-devtools@11946

@tanstack/solid-query-persist-client

npm i https://pkg.pr.new/@tanstack/solid-query-persist-client@11946

@tanstack/svelte-query

npm i https://pkg.pr.new/@tanstack/svelte-query@11946

@tanstack/svelte-query-devtools

npm i https://pkg.pr.new/@tanstack/svelte-query-devtools@11946

@tanstack/svelte-query-persist-client

npm i https://pkg.pr.new/@tanstack/svelte-query-persist-client@11946

@tanstack/vue-query

npm i https://pkg.pr.new/@tanstack/vue-query@11946

@tanstack/vue-query-devtools

npm i https://pkg.pr.new/@tanstack/vue-query-devtools@11946

commit: d65a293

github-actions · 2026-10-10T04:21:33Z

size-limit report 📦

Path	Size
react full	11.73 KB (0%)
react minimal	8.58 KB (0%)

chore(oxlint.config): load the jsdoc and vitest JS plugins only in th…

d65a293

…e overrides that use them

sukvvon self-assigned this Oct 10, 2026

sukvvon merged commit e3ef138 into main Oct 10, 2026
9 checks passed

sukvvon deleted the chore/oxlint-scope-js-plugins-to-overrides branch October 10, 2026 04:23

Navigation Menu

Repository navigation

chore(oxlint.config): load the jsdoc and vitest JS plugins only in the overrides that use them - #11946

chore(oxlint.config): load the jsdoc and vitest JS plugins only in the overrides that use them#11946
sukvvon merged 1 commit into
mainfrom
chore/oxlint-scope-js-plugins-to-overrides

sukvvon commented Oct 10, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

changeset-bot Bot commented Oct 10, 2026

Uh oh!

nx-cloud Bot commented Oct 10, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Oct 10, 2026

Uh oh!

coderabbitai Bot commented Oct 10, 2026 •

edited

Loading

Walkthrough

Changes

Uh oh!

pkg-pr-new Bot commented Oct 10, 2026

Uh oh!

github-actions Bot commented Oct 10, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

sukvvon commented Oct 10, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🎯 Changes

✅ Checklist

🚀 Release Impact

Summary by CodeRabbit

Uh oh!

changeset-bot Bot commented Oct 10, 2026

⚠️ No Changeset found

Uh oh!

nx-cloud Bot commented Oct 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Oct 10, 2026

🚀 Changeset Version Preview

🟩 Patch bumps

Uh oh!

coderabbitai Bot commented Oct 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Uh oh!

pkg-pr-new Bot commented Oct 10, 2026

Uh oh!

github-actions Bot commented Oct 10, 2026

size-limit report 📦

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

sukvvon commented Oct 10, 2026 •

edited by coderabbitai Bot

Loading

nx-cloud Bot commented Oct 10, 2026 •

edited

Loading

coderabbitai Bot commented Oct 10, 2026 •

edited

Loading