You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
chore(preact-query*): clarify why the base rules from 'eslint-config-preact' are turned off - #11928
The comment above the base rules turned off in the preact packages' eslint.config.js only described no-redeclare ("overload false positives"), but it heads four rules enabled by eslint-config-preact:
no-redeclare, no-unused-vars, no-import-assign: already checked by TypeScript.
no-duplicate-imports: already covered by import/no-duplicates, and it would flag the separate import type imports.
Update the comment in preact-query, preact-query-devtools and preact-query-persist-client to describe all four. No rule changes.
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
_________________________________________________
< Untangling your code like a pair of headphones. >
-------------------------------------------------
\
\ (\__/)
(•ㅅ•)
/ づ
✨ Finishing Touches📝 Generate docstrings
Commit to this branch
Create a new PR
🧪 Generate unit tests (beta)
Commit to this branch
Create a new PR
Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎯 Changes
The comment above the base rules turned off in the preact packages'
eslint.config.jsonly describedno-redeclare("overload false positives"), but it heads four rules enabled byeslint-config-preact:no-redeclare,no-unused-vars,no-import-assign: already checked by TypeScript.no-duplicate-imports: already covered byimport/no-duplicates, and it would flag the separateimport typeimports.Update the comment in
preact-query,preact-query-devtoolsandpreact-query-persist-clientto describe all four. No rule changes.✅ Checklist
pnpm run test:pr, or these tests do not apply to this pull request.🚀 Release Impact