refactor(lit-query): add the 'override' modifier to members that override a base class member by sukvvon · Pull Request #11906 · TanStack/query

sukvvon · 2026-10-04T17:31:36Z

🎯 Changes

Adds the TypeScript override modifier to the LitElement members that QueryClientProvider overrides: properties, connectedCallback, disconnectedCallback, willUpdate, and render.

With override, TypeScript reports an error if one of these LitElement members is renamed or removed, instead of silently turning the member into a new one.

override is erased at compile time, so the built JS and the type declarations are unchanged.

✅ Checklist

I have followed the steps in the Contributing guide.
I have tested code changes locally with pnpm run test:pr, or these tests do not apply to this pull request.
I have followed the AI contribution policy and fully understand the code in this pull request, including any code generated with AI assistance.

🚀 Release Impact

This change affects published code, and I have generated a changeset.
This change is docs/CI/dev-only (no release).

Summary by CodeRabbit

Chores
- Updated TypeScript declarations for the query client provider. No user-visible behavior changed.

…ride a base class member

changeset-bot · 2026-10-04T17:31:42Z

⚠️ No Changeset found

Latest commit: 21480ab

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

nx-cloud · 2026-10-04T17:33:01Z

View your CI Pipeline Execution ↗ for commit 9f3d616

Command	Status	Duration	Result
`nx affected --targets=test:sherif,test:knip,tes...`	✅ Succeeded	2m 29s	View ↗
`nx run-many --target=build --exclude=examples/*...`	✅ Succeeded	2s	View ↗

☁️ Nx Cloud last updated this comment at 2026-10-04 17:36:13 UTC

coderabbitai · 2026-10-04T17:33:16Z

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository: TanStack/query/.coderabbit.yaml
Review profile: CHILL
Plan: Advanced
Run ID: 6e1e8bba-ba52-426d-8337-23bf758ab989

📥 Commits

Reviewing files that changed from the base of the PR and between 688f6e0 and 9f3d616.

📒 Files selected for processing (1)

packages/lit-query/src/QueryClientProvider.ts

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 0 remain after this review.

📝 Walkthrough

Walkthrough

QueryClientProvider now marks its static properties declaration and lifecycle and render methods with TypeScript’s override modifier. The changes do not alter runtime behavior.

Changes

Lit QueryClientProvider

Layer / File(s)	Summary
Mark inherited members as overrides `packages/lit-query/src/QueryClientProvider.ts`	The static properties declaration and four methods now use the `override` modifier. Their implementations and behavior are unchanged.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Refactor

Suggested reviewers: lachlancollins

Merge Risk: ⚪ Minimal · up to 9f3d6

The change adds compile-time checks for existing Lit overrides without changing provider behavior. The resolved Lit types and configured TypeScript versions support these annotations, so no actionable merge risk is indicated.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly describes the change: adding TypeScript's `override` modifier to members that override base-class members.
Description check	✅ Passed	The description covers the changes and motivation, completes the checklist, and states the release impact using all template sections.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1…
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

📝 Generate docstrings

Commit to this branch
Create a new PR

🧪 Generate unit tests (beta)

Commit to this branch
Create a new PR

Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

github-actions · 2026-10-04T17:33:59Z

🚀 Changeset Version Preview

1 package(s) bumped directly, 24 bumped as dependents.

🟩 Patch bumps

Package	Version	Reason
`@tanstack/query-core`	5.104.1 → 5.104.2	Changeset
`@tanstack/angular-query-experimental`	5.104.1 → 5.104.2	Dependent
`@tanstack/angular-query-persist-client`	5.104.1 → 5.104.2	Dependent
`@tanstack/eslint-plugin-query`	5.104.1 → 5.104.2	Dependent
`@tanstack/lit-query`	0.2.26 → 0.2.27	Dependent
`@tanstack/preact-query`	5.104.1 → 5.104.2	Dependent
`@tanstack/preact-query-devtools`	5.104.1 → 5.104.2	Dependent
`@tanstack/preact-query-persist-client`	5.104.1 → 5.104.2	Dependent
`@tanstack/query-async-storage-persister`	5.104.1 → 5.104.2	Dependent
`@tanstack/query-broadcast-client-experimental`	5.104.1 → 5.104.2	Dependent
`@tanstack/query-devtools`	5.104.1 → 5.104.2	Dependent
`@tanstack/query-persist-client-core`	5.104.1 → 5.104.2	Dependent
`@tanstack/query-sync-storage-persister`	5.104.1 → 5.104.2	Dependent
`@tanstack/react-query`	5.104.1 → 5.104.2	Dependent
`@tanstack/react-query-devtools`	5.104.1 → 5.104.2	Dependent
`@tanstack/react-query-next-experimental`	5.104.1 → 5.104.2	Dependent
`@tanstack/react-query-persist-client`	5.104.1 → 5.104.2	Dependent
`@tanstack/solid-query`	5.104.1 → 5.104.2	Dependent
`@tanstack/solid-query-devtools`	5.104.1 → 5.104.2	Dependent
`@tanstack/solid-query-persist-client`	5.104.1 → 5.104.2	Dependent
`@tanstack/svelte-query`	6.3.1 → 6.3.2	Dependent
`@tanstack/svelte-query-devtools`	6.3.1 → 6.3.2	Dependent
`@tanstack/svelte-query-persist-client`	6.3.1 → 6.3.2	Dependent
`@tanstack/vue-query`	5.104.1 → 5.104.2	Dependent
`@tanstack/vue-query-devtools`	6.3.1 → 6.3.2	Dependent

pkg-pr-new · 2026-10-04T17:35:18Z

More templates

@tanstack/angular-query-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-experimental@11906

@tanstack/eslint-plugin-query

npm i https://pkg.pr.new/@tanstack/eslint-plugin-query@11906

@tanstack/lit-query

npm i https://pkg.pr.new/@tanstack/lit-query@11906

@tanstack/preact-query

npm i https://pkg.pr.new/@tanstack/preact-query@11906

@tanstack/preact-query-devtools

npm i https://pkg.pr.new/@tanstack/preact-query-devtools@11906

@tanstack/preact-query-persist-client

npm i https://pkg.pr.new/@tanstack/preact-query-persist-client@11906

@tanstack/query-async-storage-persister

npm i https://pkg.pr.new/@tanstack/query-async-storage-persister@11906

@tanstack/query-broadcast-client-experimental

npm i https://pkg.pr.new/@tanstack/query-broadcast-client-experimental@11906

@tanstack/query-core

npm i https://pkg.pr.new/@tanstack/query-core@11906

@tanstack/query-devtools

npm i https://pkg.pr.new/@tanstack/query-devtools@11906

@tanstack/query-persist-client-core

npm i https://pkg.pr.new/@tanstack/query-persist-client-core@11906

@tanstack/query-sync-storage-persister

npm i https://pkg.pr.new/@tanstack/query-sync-storage-persister@11906

@tanstack/react-query

npm i https://pkg.pr.new/@tanstack/react-query@11906

@tanstack/react-query-devtools

npm i https://pkg.pr.new/@tanstack/react-query-devtools@11906

@tanstack/react-query-next-experimental

npm i https://pkg.pr.new/@tanstack/react-query-next-experimental@11906

@tanstack/react-query-persist-client

npm i https://pkg.pr.new/@tanstack/react-query-persist-client@11906

@tanstack/solid-query

npm i https://pkg.pr.new/@tanstack/solid-query@11906

@tanstack/solid-query-devtools

npm i https://pkg.pr.new/@tanstack/solid-query-devtools@11906

@tanstack/solid-query-persist-client

npm i https://pkg.pr.new/@tanstack/solid-query-persist-client@11906

@tanstack/svelte-query

npm i https://pkg.pr.new/@tanstack/svelte-query@11906

@tanstack/svelte-query-devtools

npm i https://pkg.pr.new/@tanstack/svelte-query-devtools@11906

@tanstack/svelte-query-persist-client

npm i https://pkg.pr.new/@tanstack/svelte-query-persist-client@11906

@tanstack/vue-query

npm i https://pkg.pr.new/@tanstack/vue-query@11906

@tanstack/vue-query-devtools

npm i https://pkg.pr.new/@tanstack/vue-query-devtools@11906

commit: 9f3d616

github-actions · 2026-10-04T17:35:27Z

size-limit report 📦

Path	Size
react full	11.73 KB (0%)
react minimal	8.58 KB (0%)

refactor(lit-query): add the 'override' modifier to members that over…

9f3d616

…ride a base class member

sukvvon self-assigned this Oct 4, 2026

Merge branch 'main' into refactor/lit-query-add-override-modifiers

21480ab

sukvvon merged commit ec8c6de into main Oct 4, 2026
6 checks passed

sukvvon deleted the refactor/lit-query-add-override-modifiers branch October 4, 2026 18:21

Navigation Menu

Repository navigation

refactor(lit-query): add the 'override' modifier to members that override a base class member - #11906

refactor(lit-query): add the 'override' modifier to members that override a base class member#11906
sukvvon merged 2 commits into
mainfrom
refactor/lit-query-add-override-modifiers

sukvvon commented Oct 4, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

changeset-bot Bot commented Oct 4, 2026 •

edited

Loading

Uh oh!

nx-cloud Bot commented Oct 4, 2026 •

edited

Loading

Uh oh!

coderabbitai Bot commented Oct 4, 2026 •

edited

Loading

Walkthrough

Changes

Uh oh!

github-actions Bot commented Oct 4, 2026

Uh oh!

pkg-pr-new Bot commented Oct 4, 2026

Uh oh!

github-actions Bot commented Oct 4, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

sukvvon commented Oct 4, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🎯 Changes

✅ Checklist

🚀 Release Impact

Summary by CodeRabbit

Uh oh!

changeset-bot Bot commented Oct 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ No Changeset found

Uh oh!

nx-cloud Bot commented Oct 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coderabbitai Bot commented Oct 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Uh oh!

github-actions Bot commented Oct 4, 2026

🚀 Changeset Version Preview

🟩 Patch bumps

Uh oh!

pkg-pr-new Bot commented Oct 4, 2026

Uh oh!

github-actions Bot commented Oct 4, 2026

size-limit report 📦

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

sukvvon commented Oct 4, 2026 •

edited by coderabbitai Bot

Loading

changeset-bot Bot commented Oct 4, 2026 •

edited

Loading

nx-cloud Bot commented Oct 4, 2026 •

edited

Loading

coderabbitai Bot commented Oct 4, 2026 •

edited

Loading