refactor(query-core): add the 'override' modifier to members that override a base class member by sukvvon · Pull Request #11904 · TanStack/query

sukvvon · 2026-10-04T17:27:29Z

🎯 Changes

Adds the TypeScript override modifier to the query-core class members that override a member of their base class:

onSubscribe/onUnsubscribe in the Subscribable subclasses (focusManager, onlineManager, QueryObserver, QueriesObserver, MutationObserver).
The members InfiniteQueryObserver overrides from QueryObserver, including the fields that narrow the type of inherited methods.
Query#destroy, and optionalRemove in Query and Mutation.

The members were found with --noImplicitOverride. The two optionalRemove implementations were added on top, since that flag doesn't require override for an abstract member. With override, TypeScript reports an error if the base member is renamed or removed, instead of silently turning the member into a new one.

The abstract Removable#optionalRemove also gets a JSDoc description, which the implementations inherit.

override is erased at compile time:

The built JS and the type declarations are unchanged.
The only difference in the build output is that new JSDoc comment in the Removable declaration.

✅ Checklist

I have followed the steps in the Contributing guide.
I have tested code changes locally with pnpm run test:pr, or these tests do not apply to this pull request.
I have followed the AI contribution policy and fully understand the code in this pull request, including any code generated with AI assistance.

🚀 Release Impact

This change affects published code, and I have generated a changeset.
This change is docs/CI/dev-only (no release).

changeset-bot · 2026-10-04T17:27:35Z

⚠️ No Changeset found

Latest commit: b0e4edc

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

coderabbitai · 2026-10-04T17:29:04Z

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 14 seconds.

Check out review usage here.

View limit details

Limit details: You’ve used all 10 included reviews currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Repository: TanStack/query/.coderabbit.yaml
Review profile: CHILL
Plan: Advanced
Run ID: 27719ebd-6f30-46a4-8ccb-3bc7e2263775

📥 Commits

Reviewing files that changed from the base of the PR and between 688f6e0 and b0e4edc.

📒 Files selected for processing (9)

packages/query-core/src/focusManager.ts
packages/query-core/src/infiniteQueryObserver.ts
packages/query-core/src/mutation.ts
packages/query-core/src/mutationObserver.ts
packages/query-core/src/onlineManager.ts
packages/query-core/src/queriesObserver.ts
packages/query-core/src/query.ts
packages/query-core/src/queryObserver.ts
packages/query-core/src/removable.ts

✨ Finishing Touches

📝 Generate docstrings

Commit to this branch
Create a new PR

🧪 Generate unit tests (beta)

Commit to this branch
Create a new PR

Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

…rride a base class member

nx-cloud · 2026-10-04T17:29:13Z

View your CI Pipeline Execution ↗ for commit b0e4edc

Command	Status	Duration	Result
`nx affected --targets=test:sherif,test:knip,tes...`	✅ Succeeded	7m 9s	View ↗
`nx run-many --target=build --exclude=examples/*...`	✅ Succeeded	34s	View ↗

☁️ Nx Cloud last updated this comment at 2026-10-04 17:39:14 UTC

github-actions · 2026-10-04T17:31:53Z

🚀 Changeset Version Preview

1 package(s) bumped directly, 24 bumped as dependents.

🟩 Patch bumps

Package	Version	Reason
`@tanstack/query-core`	5.104.1 → 5.104.2	Changeset
`@tanstack/angular-query-experimental`	5.104.1 → 5.104.2	Dependent
`@tanstack/angular-query-persist-client`	5.104.1 → 5.104.2	Dependent
`@tanstack/eslint-plugin-query`	5.104.1 → 5.104.2	Dependent
`@tanstack/lit-query`	0.2.26 → 0.2.27	Dependent
`@tanstack/preact-query`	5.104.1 → 5.104.2	Dependent
`@tanstack/preact-query-devtools`	5.104.1 → 5.104.2	Dependent
`@tanstack/preact-query-persist-client`	5.104.1 → 5.104.2	Dependent
`@tanstack/query-async-storage-persister`	5.104.1 → 5.104.2	Dependent
`@tanstack/query-broadcast-client-experimental`	5.104.1 → 5.104.2	Dependent
`@tanstack/query-devtools`	5.104.1 → 5.104.2	Dependent
`@tanstack/query-persist-client-core`	5.104.1 → 5.104.2	Dependent
`@tanstack/query-sync-storage-persister`	5.104.1 → 5.104.2	Dependent
`@tanstack/react-query`	5.104.1 → 5.104.2	Dependent
`@tanstack/react-query-devtools`	5.104.1 → 5.104.2	Dependent
`@tanstack/react-query-next-experimental`	5.104.1 → 5.104.2	Dependent
`@tanstack/react-query-persist-client`	5.104.1 → 5.104.2	Dependent
`@tanstack/solid-query`	5.104.1 → 5.104.2	Dependent
`@tanstack/solid-query-devtools`	5.104.1 → 5.104.2	Dependent
`@tanstack/solid-query-persist-client`	5.104.1 → 5.104.2	Dependent
`@tanstack/svelte-query`	6.3.1 → 6.3.2	Dependent
`@tanstack/svelte-query-devtools`	6.3.1 → 6.3.2	Dependent
`@tanstack/svelte-query-persist-client`	6.3.1 → 6.3.2	Dependent
`@tanstack/vue-query`	5.104.1 → 5.104.2	Dependent
`@tanstack/vue-query-devtools`	6.3.1 → 6.3.2	Dependent

pkg-pr-new · 2026-10-04T17:33:10Z

More templates

@tanstack/angular-query-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-experimental@11904

@tanstack/eslint-plugin-query

npm i https://pkg.pr.new/@tanstack/eslint-plugin-query@11904

@tanstack/lit-query

npm i https://pkg.pr.new/@tanstack/lit-query@11904

@tanstack/preact-query

npm i https://pkg.pr.new/@tanstack/preact-query@11904

@tanstack/preact-query-devtools

npm i https://pkg.pr.new/@tanstack/preact-query-devtools@11904

@tanstack/preact-query-persist-client

npm i https://pkg.pr.new/@tanstack/preact-query-persist-client@11904

@tanstack/query-async-storage-persister

npm i https://pkg.pr.new/@tanstack/query-async-storage-persister@11904

@tanstack/query-broadcast-client-experimental

npm i https://pkg.pr.new/@tanstack/query-broadcast-client-experimental@11904

@tanstack/query-core

npm i https://pkg.pr.new/@tanstack/query-core@11904

@tanstack/query-devtools

npm i https://pkg.pr.new/@tanstack/query-devtools@11904

@tanstack/query-persist-client-core

npm i https://pkg.pr.new/@tanstack/query-persist-client-core@11904

@tanstack/query-sync-storage-persister

npm i https://pkg.pr.new/@tanstack/query-sync-storage-persister@11904

@tanstack/react-query

npm i https://pkg.pr.new/@tanstack/react-query@11904

@tanstack/react-query-devtools

npm i https://pkg.pr.new/@tanstack/react-query-devtools@11904

@tanstack/react-query-next-experimental

npm i https://pkg.pr.new/@tanstack/react-query-next-experimental@11904

@tanstack/react-query-persist-client

npm i https://pkg.pr.new/@tanstack/react-query-persist-client@11904

@tanstack/solid-query

npm i https://pkg.pr.new/@tanstack/solid-query@11904

@tanstack/solid-query-devtools

npm i https://pkg.pr.new/@tanstack/solid-query-devtools@11904

@tanstack/solid-query-persist-client

npm i https://pkg.pr.new/@tanstack/solid-query-persist-client@11904

@tanstack/svelte-query

npm i https://pkg.pr.new/@tanstack/svelte-query@11904

@tanstack/svelte-query-devtools

npm i https://pkg.pr.new/@tanstack/svelte-query-devtools@11904

@tanstack/svelte-query-persist-client

npm i https://pkg.pr.new/@tanstack/svelte-query-persist-client@11904

@tanstack/vue-query

npm i https://pkg.pr.new/@tanstack/vue-query@11904

@tanstack/vue-query-devtools

npm i https://pkg.pr.new/@tanstack/vue-query-devtools@11904

commit: b0e4edc

github-actions · 2026-10-04T17:33:51Z

size-limit report 📦

Path	Size
react full	11.73 KB (0%)
react minimal	8.58 KB (0%)

sukvvon self-assigned this Oct 4, 2026

refactor(query-core): add the 'override' modifier to members that ove…

b0e4edc

…rride a base class member

sukvvon force-pushed the refactor/add-override-modifiers branch from 41fcfe9 to b0e4edc Compare October 4, 2026 17:29

sukvvon changed the title ~~refactor(*): add the 'override' modifier to members that override a base class member~~ refactor(query-core): add the 'override' modifier to members that override a base class member Oct 4, 2026

sukvvon merged commit 65f762e into main Oct 4, 2026
9 checks passed

sukvvon deleted the refactor/add-override-modifiers branch October 4, 2026 18:20

Navigation Menu

Repository navigation

refactor(query-core): add the 'override' modifier to members that override a base class member - #11904

refactor(query-core): add the 'override' modifier to members that override a base class member#11904
sukvvon merged 1 commit into
mainfrom
refactor/add-override-modifiers

sukvvon commented Oct 4, 2026 •

edited

Loading

Uh oh!

changeset-bot Bot commented Oct 4, 2026 •

edited

Loading

Uh oh!

coderabbitai Bot commented Oct 4, 2026 •

edited

Loading

Review limit reached

Uh oh!

nx-cloud Bot commented Oct 4, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Oct 4, 2026

Uh oh!

pkg-pr-new Bot commented Oct 4, 2026

Uh oh!

github-actions Bot commented Oct 4, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

sukvvon commented Oct 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🎯 Changes

✅ Checklist

🚀 Release Impact

Uh oh!

changeset-bot Bot commented Oct 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ No Changeset found

Uh oh!

coderabbitai Bot commented Oct 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review limit reached

Uh oh!

nx-cloud Bot commented Oct 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Oct 4, 2026

🚀 Changeset Version Preview

🟩 Patch bumps

Uh oh!

pkg-pr-new Bot commented Oct 4, 2026

Uh oh!

github-actions Bot commented Oct 4, 2026

size-limit report 📦

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

sukvvon commented Oct 4, 2026 •

edited

Loading

changeset-bot Bot commented Oct 4, 2026 •

edited

Loading

coderabbitai Bot commented Oct 4, 2026 •

edited

Loading

nx-cloud Bot commented Oct 4, 2026 •

edited

Loading