Skip to content

chore(preact-query-devtools): replace the stale 'root.tsdown.config.js' copy with a symlink to the shared config - #11864

Merged
sukvvon merged 1 commit into
mainfrom
chore/preact-query-devtools-root-tsdown-config-symlink
Oct 3, 2026
Merged

sukvvon merged 1 commit into
mainfrom
chore/preact-query-devtools-root-tsdown-config-symlink

Conversation

@sukvvon

@sukvvon sukvvon commented Oct 3, 2026 •

Copy link
Copy Markdown
Member

🎯 Changes

Replaces packages/preact-query-devtools/root.tsdown.config.js, a regular file copied from scripts/getTsdownConfig.js, with a symlink to it like the other packages (../../scripts/getTsdownConfig.js).

The copy was missing the shared config's transform target:

inputOptions: { transform: { target: 'es2022' } },

The build output of @tanstack/preact-query-devtools is the same before and after this change, since its source doesn't use private class fields, so no changeset is needed.

✅ Checklist

  • I have followed the steps in the Contributing guide.
  • I have tested code changes locally with pnpm run test:pr, or these tests do not apply to this pull request.
  • I have followed the AI contribution policy and fully understand the code in this pull request, including any code generated with AI assistance.

🚀 Release Impact

  • This change affects published code, and I have generated a changeset.
  • This change is docs/CI/dev-only (no release).

Summary by CodeRabbit

  • Chores
    • Removed build configuration presets for the devtools package. This change affects package build setup only; it does not add or remove any user-facing features, change how the devtools work, or alter the experience within the product. No changes to app functionality are included in this release.

@sukvvon sukvvon self-assigned this Oct 3, 2026
@changeset-bot

changeset-bot Bot commented Oct 3, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 76d81c4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@nx-cloud

nx-cloud Bot commented Oct 3, 2026 •

Copy link
Copy Markdown

View your CI Pipeline Execution ↗ for commit 76d81c4

Command Status Duration Result
nx run-many --target=build --exclude=examples/*... ✅ Succeeded 2s View ↗
nx affected --targets=test:sherif,test:knip,tes... ✅ Succeeded 1m 20s View ↗

☁️ Nx Cloud last updated this comment at 2026-10-03 20:31:20 UTC

@github-actions

github-actions Bot commented Oct 3, 2026

Copy link
Copy Markdown
Contributor

🚀 Changeset Version Preview

1 package(s) bumped directly, 24 bumped as dependents.

🟩 Patch bumps

Package Version Reason
@tanstack/query-core 5.104.1 → 5.104.2 Changeset
@tanstack/angular-query-experimental 5.104.1 → 5.104.2 Dependent
@tanstack/angular-query-persist-client 5.104.1 → 5.104.2 Dependent
@tanstack/eslint-plugin-query 5.104.1 → 5.104.2 Dependent
@tanstack/lit-query 0.2.26 → 0.2.27 Dependent
@tanstack/preact-query 5.104.1 → 5.104.2 Dependent
@tanstack/preact-query-devtools 5.104.1 → 5.104.2 Dependent
@tanstack/preact-query-persist-client 5.104.1 → 5.104.2 Dependent
@tanstack/query-async-storage-persister 5.104.1 → 5.104.2 Dependent
@tanstack/query-broadcast-client-experimental 5.104.1 → 5.104.2 Dependent
@tanstack/query-devtools 5.104.1 → 5.104.2 Dependent
@tanstack/query-persist-client-core 5.104.1 → 5.104.2 Dependent
@tanstack/query-sync-storage-persister 5.104.1 → 5.104.2 Dependent
@tanstack/react-query 5.104.1 → 5.104.2 Dependent
@tanstack/react-query-devtools 5.104.1 → 5.104.2 Dependent
@tanstack/react-query-next-experimental 5.104.1 → 5.104.2 Dependent
@tanstack/react-query-persist-client 5.104.1 → 5.104.2 Dependent
@tanstack/solid-query 5.104.1 → 5.104.2 Dependent
@tanstack/solid-query-devtools 5.104.1 → 5.104.2 Dependent
@tanstack/solid-query-persist-client 5.104.1 → 5.104.2 Dependent
@tanstack/svelte-query 6.3.1 → 6.3.2 Dependent
@tanstack/svelte-query-devtools 6.3.1 → 6.3.2 Dependent
@tanstack/svelte-query-persist-client 6.3.1 → 6.3.2 Dependent
@tanstack/vue-query 5.104.1 → 5.104.2 Dependent
@tanstack/vue-query-devtools 6.3.1 → 6.3.2 Dependent

@coderabbitai

coderabbitai Bot commented Oct 3, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Repository: TanStack/query/.coderabbit.yaml
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 513bb6aa-7957-432f-ab52-6478063136e2
📥 Commits

Reviewing files that changed from the base of the PR and between 4acb176 and 76d81c4.

📒 Files selected for processing (2)
  • packages/preact-query-devtools/root.tsdown.config.js
  • packages/preact-query-devtools/root.tsdown.config.js

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 8 remain after this review.


📝 Walkthrough

Walkthrough

The Preact Query Devtools root build configuration was removed. It defined modern and legacy targets, output directories, and shared build settings.

Changes

Devtools build configuration

Layer / File(s) Summary
Remove build configurations
packages/preact-query-devtools/root.tsdown.config.js
The file and its modernConfig and legacyConfig exports were removed, including target lists, output directories, and shared build settings.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Other

Merge Risk: ⚪ Minimal · up to 76d81

The Devtools build configuration continues to use the expected modern and legacy outputs; no actionable merge risk remains.

Architecture Summary

Architecture risk: 🔵 Low · up to 76d81

The change affects 1 system.

Changed systems: packages/preact-query-devtools

Architecture concerns
No architecture-level concerns identified.

Review details

Systems and components

  • observed — packages/preact-query-devtools (library) was modified; 1 changed file maps to changed impact.

Before / after behavior

  • observed — Modified behavior in packages/preact-query-devtools/root.tsdown.config.js: The file and its modernConfig and legacyConfig exports were removed, including their separate target lists, output directories (build/modern and build/legacy), and shared build settings.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly describes the main change: replacing the stale config copy with a symlink to the shared config. It is longer than necessary, but remains specific and readable.
Description check ✅ Passed The description explains the change and its motivation, completes the checklist, and states the release impact. It follows all required template sections.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@pkg-pr-new

pkg-pr-new Bot commented Oct 3, 2026

Copy link
Copy Markdown
More templates

@tanstack/angular-query-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-experimental@11864

@tanstack/eslint-plugin-query

npm i https://pkg.pr.new/@tanstack/eslint-plugin-query@11864

@tanstack/lit-query

npm i https://pkg.pr.new/@tanstack/lit-query@11864

@tanstack/preact-query

npm i https://pkg.pr.new/@tanstack/preact-query@11864

@tanstack/preact-query-devtools

npm i https://pkg.pr.new/@tanstack/preact-query-devtools@11864

@tanstack/preact-query-persist-client

npm i https://pkg.pr.new/@tanstack/preact-query-persist-client@11864

@tanstack/query-async-storage-persister

npm i https://pkg.pr.new/@tanstack/query-async-storage-persister@11864

@tanstack/query-broadcast-client-experimental

npm i https://pkg.pr.new/@tanstack/query-broadcast-client-experimental@11864

@tanstack/query-core

npm i https://pkg.pr.new/@tanstack/query-core@11864

@tanstack/query-devtools

npm i https://pkg.pr.new/@tanstack/query-devtools@11864

@tanstack/query-persist-client-core

npm i https://pkg.pr.new/@tanstack/query-persist-client-core@11864

@tanstack/query-sync-storage-persister

npm i https://pkg.pr.new/@tanstack/query-sync-storage-persister@11864

@tanstack/react-query

npm i https://pkg.pr.new/@tanstack/react-query@11864

@tanstack/react-query-devtools

npm i https://pkg.pr.new/@tanstack/react-query-devtools@11864

@tanstack/react-query-next-experimental

npm i https://pkg.pr.new/@tanstack/react-query-next-experimental@11864

@tanstack/react-query-persist-client

npm i https://pkg.pr.new/@tanstack/react-query-persist-client@11864

@tanstack/solid-query

npm i https://pkg.pr.new/@tanstack/solid-query@11864

@tanstack/solid-query-devtools

npm i https://pkg.pr.new/@tanstack/solid-query-devtools@11864

@tanstack/solid-query-persist-client

npm i https://pkg.pr.new/@tanstack/solid-query-persist-client@11864

@tanstack/svelte-query

npm i https://pkg.pr.new/@tanstack/svelte-query@11864

@tanstack/svelte-query-devtools

npm i https://pkg.pr.new/@tanstack/svelte-query-devtools@11864

@tanstack/svelte-query-persist-client

npm i https://pkg.pr.new/@tanstack/svelte-query-persist-client@11864

@tanstack/vue-query

npm i https://pkg.pr.new/@tanstack/vue-query@11864

@tanstack/vue-query-devtools

npm i https://pkg.pr.new/@tanstack/vue-query-devtools@11864

commit: 76d81c4

@github-actions

github-actions Bot commented Oct 3, 2026

Copy link
Copy Markdown
Contributor

size-limit report 📦

Path Size
react full 11.73 KB (0%)
react minimal 8.58 KB (0%)

@sukvvon
sukvvon merged commit a83ce66 into main Oct 3, 2026
9 checks passed
@sukvvon
sukvvon deleted the chore/preact-query-devtools-root-tsdown-config-symlink branch October 3, 2026 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant