test(query-core/mutationCache): add test for deleting scope when removing the only mutation in that scope by sukvvon · Pull Request #10181 · TanStack/query

sukvvon · 2026-02-24T08:05:36Z

🎯 Changes

Add a test to verify that MutationCache.remove deletes the scope entry when removing the only mutation in that scope.

This improves mutationCache.ts statement coverage (96.72% → 100%) by covering the else if branch at lines 148-149.

✅ Checklist

I have followed the steps in the Contributing guide.
I have tested this code locally with pnpm run test:pr.

🚀 Release Impact

This change affects published code, and I have generated a changeset.
This change is docs/CI/dev-only (no release).

Summary by CodeRabbit

Tests
- Added test coverage for MutationCache scope and mutation removal behavior.

…ving the only mutation in that scope

changeset-bot · 2026-02-24T08:05:41Z

⚠️ No Changeset found

Latest commit: c276364

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

coderabbitai · 2026-02-24T08:05:57Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

Configuration used: defaults

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between eb7dca5 and c276364.

📒 Files selected for processing (1)

packages/query-core/src/__tests__/mutationCache.test.tsx

📝 Walkthrough

Walkthrough

Adds a new test case to MutationCache that verifies when the only mutation within a given scope is removed, both the mutation and the scope are deleted from the cache, resulting in an empty cache.

Changes

Cohort / File(s)	Summary
MutationCache Test Coverage `packages/query-core/src/__tests__/mutationCache.test.tsx`	New test case for scoped mutation removal behavior when removing the sole mutation in a scope.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

Possibly related PRs

test(query-core/mutationCache): add test for 'remove' splicing target mutation from scope with multiple mutations #10103 — Tests removing the only mutation within a scoped context, related scope cleanup validation
test(query-core/mutation): add test for 'optionalRemove' when remaining observer exists #10127 — Tests mutation removal behavior with optionalRemove and observer presence, related mutation-removal logic

Suggested labels

package: query-core

Poem

🐰 A scope once held a mutation dear,
Now removed, it's crystal clear—
When one departs, the whole must go,
The cache stays fresh with empty flow! ✨

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Title check	✅ Passed	The pull request title clearly and specifically describes the main change: adding a test for scope deletion when removing the only mutation in that scope.
Description check	✅ Passed	The pull request description follows the repository template with all required sections completed, including detailed changes, a fully checked checklist, and appropriate release impact selection.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings (stacked PR)
📝 Generate docstrings (commit on current branch)

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

nx-cloud · 2026-02-24T08:06:05Z

View your CI Pipeline Execution ↗ for commit c276364

Command	Status	Duration	Result
`nx affected --targets=test:sherif,test:knip,tes...`	✅ Succeeded	3m 57s	View ↗
`nx run-many --target=build --exclude=examples/*...`	✅ Succeeded	1s	View ↗

☁️ Nx Cloud last updated this comment at 2026-02-24 08:10:43 UTC

pkg-pr-new · 2026-02-24T08:08:34Z

More templates

@tanstack/angular-query-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-experimental@10181

@tanstack/eslint-plugin-query

npm i https://pkg.pr.new/@tanstack/eslint-plugin-query@10181

@tanstack/preact-query

npm i https://pkg.pr.new/@tanstack/preact-query@10181

@tanstack/query-async-storage-persister

npm i https://pkg.pr.new/@tanstack/query-async-storage-persister@10181

@tanstack/query-broadcast-client-experimental

npm i https://pkg.pr.new/@tanstack/query-broadcast-client-experimental@10181

@tanstack/query-core

npm i https://pkg.pr.new/@tanstack/query-core@10181

@tanstack/query-devtools

npm i https://pkg.pr.new/@tanstack/query-devtools@10181

@tanstack/query-persist-client-core

npm i https://pkg.pr.new/@tanstack/query-persist-client-core@10181

@tanstack/query-sync-storage-persister

npm i https://pkg.pr.new/@tanstack/query-sync-storage-persister@10181

@tanstack/react-query

npm i https://pkg.pr.new/@tanstack/react-query@10181

@tanstack/react-query-devtools

npm i https://pkg.pr.new/@tanstack/react-query-devtools@10181

@tanstack/react-query-next-experimental

npm i https://pkg.pr.new/@tanstack/react-query-next-experimental@10181

@tanstack/react-query-persist-client

npm i https://pkg.pr.new/@tanstack/react-query-persist-client@10181

@tanstack/solid-query

npm i https://pkg.pr.new/@tanstack/solid-query@10181

@tanstack/solid-query-devtools

npm i https://pkg.pr.new/@tanstack/solid-query-devtools@10181

@tanstack/solid-query-persist-client

npm i https://pkg.pr.new/@tanstack/solid-query-persist-client@10181

@tanstack/svelte-query

npm i https://pkg.pr.new/@tanstack/svelte-query@10181

@tanstack/svelte-query-devtools

npm i https://pkg.pr.new/@tanstack/svelte-query-devtools@10181

@tanstack/svelte-query-persist-client

npm i https://pkg.pr.new/@tanstack/svelte-query-persist-client@10181

@tanstack/vue-query

npm i https://pkg.pr.new/@tanstack/vue-query@10181

@tanstack/vue-query-devtools

npm i https://pkg.pr.new/@tanstack/vue-query-devtools@10181

commit: c276364

test(query-core/mutationCache): add test for deleting scope when remo…

c276364

…ving the only mutation in that scope

github-actions bot added the package: query-core label Feb 24, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

test(query-core/mutationCache): add test for deleting scope when removing the only mutation in that scope#10181

test(query-core/mutationCache): add test for deleting scope when removing the only mutation in that scope#10181
sukvvon wants to merge 1 commit intoTanStack:mainfrom
sukvvon:test/query-core-mutationCache-remove-single-scope

sukvvon commented Feb 24, 2026 •

edited by coderabbitai bot

Loading

Uh oh!

changeset-bot bot commented Feb 24, 2026

Uh oh!

coderabbitai bot commented Feb 24, 2026 •

edited

Loading

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Suggested labels

Poem

Uh oh!

nx-cloud bot commented Feb 24, 2026 •

edited

Loading

Uh oh!

pkg-pr-new bot commented Feb 24, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Conversation

sukvvon commented Feb 24, 2026 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🎯 Changes

✅ Checklist

🚀 Release Impact

Summary by CodeRabbit

Uh oh!

changeset-bot bot commented Feb 24, 2026

⚠️ No Changeset found

Uh oh!

coderabbitai bot commented Feb 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Suggested labels

Poem

Uh oh!

nx-cloud bot commented Feb 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pkg-pr-new bot commented Feb 24, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

sukvvon commented Feb 24, 2026 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Feb 24, 2026 •

edited

Loading

nx-cloud bot commented Feb 24, 2026 •

edited

Loading