queries retrying even though option is set to false

[alexandernanberg]

Describe the bug

While upgrading to v2 I noticed that some tests broke because useQuery does no longer use the config from the provider when you prefetch.

To Reproduce

Steps to reproduce the behavior:

1. Go to https://codesandbox.io/s/sweet-resonance-zu0em?file=/src/App.js
2. Check the console
3. See multiple logs from react-query trying to retry even though the option is set to false

Expected behavior

Queries does not retry if option is set to false

Screenshots
N/A

Desktop (please complete the following information):
N/A

Smartphone (please complete the following information):
N/A

Additional context
N/A

[otaciliolacerda]

The problems seems to be that prefetchQuery do not use the context configuration so it is retrying 3 times (default). useQuery is working as expected.

useEffect(() => {
    queryCache.prefetchQuery('resource', () => getResource(), { retry: false });
  }, []);

[alexandernanberg]

Sure, but I wouldn't expect the prefetch to retry by default 🤔 IMO that should be handled by the useQuery hook

[tannerlinsley]

I would accept a PR to make prefetching default to retry: false

[otaciliolacerda]

Do you want to change any other defaults in prefetching?
EDIT: what would this change be? A bugfix?

[tannerlinsley]

🎉 This issue has been resolved in version 2.4.20 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀