docs: Reusable styled form component#583
Closed
michaelbrusegard wants to merge 10 commits intoTanStack:mainfrom
Closed
docs: Reusable styled form component#583michaelbrusegard wants to merge 10 commits intoTanStack:mainfrom
michaelbrusegard wants to merge 10 commits intoTanStack:mainfrom
Conversation
… example This commit adds the base files needed to start developing an example of a reusable styled form component.
This commit adds a new checkbox input component and takes out the error message span and icon from the Text component into it's own component.
…bscribe components
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
Member
|
Closing in favor of #825, which itself will be closed with a different API in mind. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is currently a WIP. Please close the pull request if you feel like this addition is unnecessary, I don't want to waste anybody's time.
Current issues
Current issues I have been unable to solve and need help with (there may be more, and I will add them if I remember):
anyfor the time being.phoneNumberfield to re-trigger when thecountryfield is updated. This is because the validation of the phone number is based on which country is selected.<Form.Field.Error>withuseEffectandsetTimeout, but maybe there is a better solution.Use case
I feel like creating a component like this can be useful for big applications that have many forms. It can be argued for that it is unnecessary because you can create the components separately from the Form logic, but there is still a lot of boilerplate that a solutions like this removes.
Additions
Here is a screenshot of the example, keep in mind that the validation is triggered only after the first submit:
