fix(form-core): Validate fields without instances#2001
Merged
LeCarbonator merged 1 commit intoTanStack:mainfrom Jan 24, 2026
Merged
fix(form-core): Validate fields without instances#2001LeCarbonator merged 1 commit intoTanStack:mainfrom
LeCarbonator merged 1 commit intoTanStack:mainfrom
Conversation
🦋 Changeset detectedLatest commit: e710f91 The changes in this PR will be included in the next version bump. This PR includes changesets to release 13 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
View your CI Pipeline Execution ↗ for commit e710f91
☁️ Nx Cloud last updated this comment at |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2001 +/- ##
==========================================
- Coverage 90.35% 89.48% -0.87%
==========================================
Files 38 48 +10
Lines 1752 1950 +198
Branches 444 491 +47
==========================================
+ Hits 1583 1745 +162
- Misses 149 184 +35
- Partials 20 21 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎯 Changes
Fixes: #1865
So far, in case when there was no field instance - validation was not run for a given field.
Explicit call to form validation will not be expensive, so it will be better to have this as fallback than nothing at all.
✅ Checklist
pnpm test:pr.🚀 Release Impact