fix(core): move to native compatible uuid#1753
Merged
harry-whorlow merged 5 commits intoSep 25, 2025
Merged
Conversation
🦋 Changeset detectedLatest commit: 3782282 The changes in this PR will be included in the next version bump. This PR includes changesets to release 9 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
View your CI Pipeline Execution ↗ for commit 3782282
☁️ Nx Cloud last updated this comment at |
Contributor
Author
|
looks to fix #1744 |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1753 +/- ##
==========================================
+ Coverage 90.35% 90.47% +0.11%
==========================================
Files 38 38
Lines 1752 1784 +32
Branches 444 451 +7
==========================================
+ Hits 1583 1614 +31
- Misses 149 150 +1
Partials 20 20 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
harry-whorlow
marked this pull request as ready for review
September 23, 2025 15:01
Contributor
Author
|
Somehow I missed some of my experimental code and it was included into the PR, this returns formId to a getter again |
Balastrong
approved these changes
Sep 24, 2025
harry-whorlow
force-pushed
the
native-compatible-uuid
branch
2 times, most recently
from
September 24, 2025 20:24
900030d to
47ce956
Compare
harry-whorlow
force-pushed
the
native-compatible-uuid
branch
from
September 24, 2025 20:26
47ce956 to
6417a18
Compare
harry-whorlow
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements @lukeed/uuid so we're not relying on crypto.getRandomValue in native environments.