-
-
Notifications
You must be signed in to change notification settings - Fork 499
fix(form-core): infer formOptions
parameter's type correctly
#1679
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
fix(form-core): infer formOptions
parameter's type correctly
#1679
Conversation
a-is-4-adam
commented
Aug 6, 2025
- Add TFormData generic parameter to formOptions function
- Add test to verify listener type preservation with formOptions
- Current implementation has intentional type issues for investigation
- Add TFormData generic parameter to formOptions function - Add test to verify listener type preservation with formOptions - Current implementation has intentional type issues for investigation
View your CI Pipeline Execution ↗ for commit b2f9abe
☁️ Nx Cloud last updated this comment at |
There was a suggestion with using reverse mapped types, but I'll test it locally first because it may end up being too separated from the original types. Do you mind if I commit the changes here if they work? |
Yeah go for it :) |
well, it was worth a shot. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1679 +/- ##
=======================================
Coverage 90.50% 90.50%
=======================================
Files 37 37
Lines 1685 1685
Branches 421 421
=======================================
Hits 1525 1525
Misses 143 143
Partials 17 17 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Alright, now we're talking. Would you mind giving this implementation a user test first? @a-is-4-adam |
…-core-formOptions-type-preservation-wip
formOptions
parameter's type correctly