fix: type unions should now work properly#1180
Merged
crutchcorn merged 5 commits intoreusable-app-hookfrom Feb 28, 2025
Merged
Conversation
|
View your CI Pipeline Execution ↗ for commit b7c61ab.
☁️ Nx Cloud last updated this comment at |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## reusable-app-hook #1180 +/- ##
=====================================================
- Coverage 45.51% 0 -45.52%
=====================================================
Files 13 0 -13
Lines 145 0 -145
Branches 25 0 -25
=====================================================
- Hits 66 0 -66
+ Misses 69 0 -69
+ Partials 10 0 -10 ☔ View full report in Codecov by Sentry. |
Co-authored-by: irwinarruda <arruda.irwin@gmail.com>
Co-authored-by: irwinarruda <arruda.irwin@gmail.com>
crutchcorn
force-pushed
the
reusable-app-hook-fixed-union-types
branch
from
f2d04a4 to
5c8870f
Compare
crutchcorn
added a commit
that referenced
this pull request
Mar 1, 2025
* feat: add ability to create custom form hook for better app-facing DX * test: add tests for createFormHook * feat: add withForm HOC * Revert "feat: add withForm HOC" This reverts commit 36e42f0. * chore: fix typings from `main` * Reapply "feat: add withForm HOC" This reverts commit b6e0f91. * ci: apply automated fixes and generate docs * chore: fix CI * feat: add form components functionality * ci: apply automated fixes and generate docs * fix: type unions should now work properly (#1180) * fix: type unions should now work properly Co-authored-by: irwinarruda <arruda.irwin@gmail.com> * ci: apply automated fixes and generate docs * chore: reintroduce TDepth for infinate depth issues Co-authored-by: irwinarruda <arruda.irwin@gmail.com> * ci: apply automated fixes and generate docs * test: add large schema test --------- Co-authored-by: irwinarruda <arruda.irwin@gmail.com> Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com> * docs: add initial philosophy doc * docs: add initial docs for form composition * docs: add withForm docs examples * docs: add form composition page to docs config * fix: attempt to fix infinite loops with createFormHook * ci: apply automated fixes and generate docs * docs: Apply suggestions from code review Co-authored-by: LeCarbonator <18158911+LeCarbonator@users.noreply.github.com> * feat: make minimum TS supported version 5.4, remove NoInfer hack * chore: fix Sherif TS errors * ci: apply automated fixes and generate docs * docs: add Mermaid chart from the GitHub PR --------- Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com> Co-authored-by: irwinarruda <arruda.irwin@gmail.com> Co-authored-by: LeCarbonator <18158911+LeCarbonator@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Taken from #724 and rebased onto the current codebase.