If validation fails in `onSubmitAsync`, error does not resolve with a valid input

[AkshayPathak]

Describe the bug

To prevent the submission of a pristine form, the recommended way to validate is in the onSubmitAsync. In the code sandbox, the onBlur and onSubmitAsync functions both have the same Zod validator.

When a pristine form is submitted, an error on the first name appears. However, if the input is modified, the error does not resolve and also does not allow the form to be submitted.

Your minimal, reproducible example

https://codesandbox.io/p/sandbox/confident-tereshkova-2xl2hj?embed=1&file=%2Fsrc%2Findex.tsx%3A1%2C1

Steps to reproduce

1. Navigate to sandbox
2. Click Submit without touching any of the fields. You will see the validation error shown to the right of the First Name input.
3. Enter some text in the First Name input. Notice that the validation message does not disappear and even with a valid input, the Submit button is not enabled.

Expected behavior

The error should clear after a validation error with a pristine form in the onSubmitAsync function and allow the form to be submitted.

How often does this bug happen?

Every time

Screenshots or Videos

No response

Platform

• OS: Linux
• Browsers: Chrome, Firefox

Tanstack Form adapter

react-form

TanStack Form version

0.4.1

TypeScript version

No response

Additional context

No response

[juliendelort]

I've noticed this as well (I mentioned it in point 2 of this PR description). I believe this is a side effect of separating it out validation per event (it's possible to have different validation rules in onChange, onBlur, onSubmitAsync for example, so the concept of whether a field is valid or not at a given time is fuzzy).

I've opened a discussion here.

[crutchcorn]

While this appears unrelated at first glance to #490, I think that when we fix 490, we'll fix this one as well

[crutchcorn]

This should be fixed in 0.10.x. Please test this release out and let us know what you think!

If you run into an issue, let's open a new issue given how many releases we've had since 😊