fix(devtools): ignore the hotkey while focus is in an editable element#325
Merged
AlemTuzlak merged 3 commits intoTanStack:mainfrom Jan 27, 2026
Merged
fix(devtools): ignore the hotkey while focus is in an editable element#325AlemTuzlak merged 3 commits intoTanStack:mainfrom
AlemTuzlak merged 3 commits intoTanStack:mainfrom
Conversation
…ing the createShortcut callback
🦋 Changeset detectedLatest commit: 83e4351 The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
Author
|
@AlemTuzlak Can I get your eyes on this? |
Collaborator
|
so where does this work exactly, not only contentEditable fields but inputs, textareas etc right? |
Contributor
Author
|
@AlemTuzlak That’s correct. When I typed into those fields and pressed Shift+A as part of my sentence, DevTools opened instead of the character being entered. This update resolves the issue. |
AlemTuzlak
approved these changes
Jan 22, 2026
|
View your CI Pipeline Execution ↗ for commit 83e4351
☁️ Nx Cloud last updated this comment at |
More templates
@tanstack/devtools
@tanstack/devtools-client
@tanstack/devtools-ui
@tanstack/devtools-utils
@tanstack/devtools-vite
@tanstack/devtools-event-bus
@tanstack/devtools-event-client
@tanstack/preact-devtools
@tanstack/react-devtools
@tanstack/solid-devtools
@tanstack/vue-devtools
commit: |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎯 Changes
This PR keeps the hotkey working globally, but prevents accidental toggles while typing in an editable field by guarding the createShortcut callback.
✅ Checklist
pnpm test:pr.🚀 Release Impact